Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
- Prefer https URLs for cloning from GitHub, add SYNTHTOOL_USE_SSH to use ssh ([#120](https://github.com/googleapis/synthtool/pull/120))
- Drop the PR template for nodejs ([#117](https://github.com/googleapis/synthtool/pull/117))
- Update github issue templates ([#116](https://github.com/googleapis/synthtool/pull/116))
- Incude build/ in eslint ignore ([#115](https://github.com/googleapis/synthtool/pull/115))
- Include build/ in eslint ignore ([#115](https://github.com/googleapis/synthtool/pull/115))
- feat: make npm link work for system tests ([#114](https://github.com/googleapis/synthtool/pull/114))
- fix: update nodejs issue templates ([#112](https://github.com/googleapis/synthtool/pull/112))
- feat(node): add node11 test env ([#110](https://github.com/googleapis/synthtool/pull/110))
Expand Down
2 changes: 1 addition & 1 deletion synthtool/gcp/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def _load_repo_metadata(
* `api_id` - The API ID associated with the service. Fully qualified identifier use to
enable a service in the cloud platform (e.g. monitoring.googleapis.com)
* `requires_billing` - Whether or not the API requires billing to be configured on the
customer's acocunt
customer's account

Args:
metadata_file (str, optional): Path to the metadata json file
Expand Down
2 changes: 1 addition & 1 deletion synthtool/gcp/gapic_bazel.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def _generate_code(
if not proto_output_path:
proto_output_path = output_dir / "protos"
if language == "python":
# place protos alongsize the *_pb2.py files
# place protos alongside the *_pb2.py files
proto_output_path = (
output_dir / f"google/cloud/{service}_{version}/proto"
)
Expand Down
2 changes: 1 addition & 1 deletion synthtool/gcp/gapic_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def _generate_code(
# appropriate place.
proto_output_path = genfiles / "protos"
if language == "python":
# place protos alongsize the *_pb2.py files
# place protos alongside the *_pb2.py files
proto_output_path = genfiles / f"google/cloud/{service}_{version}/proto"
os.makedirs(proto_output_path, exist_ok=True)

Expand Down
4 changes: 2 additions & 2 deletions synthtool/gcp/templates/python_samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

## Python Samples for {{ metadata['repo']['name_pretty'] }}

This directory contains samples for {{ metadata['repo']['name_pretty'] }}, which may be used as a refererence for how to use this product. {% if metadata['repo']['custom_content'] is defined %}
This directory contains samples for {{ metadata['repo']['name_pretty'] }}, which may be used as a reference for how to use this product. {% if metadata['repo']['custom_content'] is defined %}
{{ metadata['repo']['custom_content']}}{% endif %}{% if metadata['repo']['samples']|length %}
Samples, quickstarts, and other documentation are available at <a href="{{ metadata['repo']['product_documentation'] }}">cloud.google.com</a>.
{% for sample in range(metadata['repo']['samples']|length) %}
Expand All @@ -18,7 +18,7 @@ Samples, quickstarts, and other documentation are available at <a href="{{ metad

To run this sample:

1. If this is your first time working with GCP products, you will need to set up [the Cloud SDK][cloud_sdk] or utilize [Google Cloud Shell][gcloud_shell]. This sample may [require authetication][authentication]{% if metadata['repo']['requires_billing'] %} and you will need to [enable billing][enable_billing]{% endif %}.
1. If this is your first time working with GCP products, you will need to set up [the Cloud SDK][cloud_sdk] or utilize [Google Cloud Shell][gcloud_shell]. This sample may [require authentication][authentication]{% if metadata['repo']['requires_billing'] %} and you will need to [enable billing][enable_billing]{% endif %}.

1. Make a fork of this repo and clone the branch locally, then navigate to the sample directory you want to use.

Expand Down
2 changes: 1 addition & 1 deletion synthtool/languages/python_mono_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def apply_client_specific_post_processing(
== 0
)
if number_of_paths_with_replacements:
# Ensure that the numner of paths where a replacement occurred matches the number of paths.
# Ensure that the number of paths where a replacement occurred matches the number of paths.
assert number_of_paths_with_replacements == len(
replacement["paths"]
)
Expand Down
2 changes: 1 addition & 1 deletion synthtool/protos/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Synthtool and Autosynth Protocol

**Synthtool** generates client library source code according to the currrent
**Synthtool** generates client library source code according to the current
state of the source repo, and upstream repos like
[googleapis/googleapis](https://github.com/googleapis/googleapis).

Expand Down
2 changes: 1 addition & 1 deletion synthtool/py_templating_instructions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ Each sample in `samples` has the attributes:
- `file` : The main file associated with this sample
- `runnable` (Optional) : Either True/False, depending on whether this sample is made to be run by running the above file name, or not.
- `custom_content` (Optional) : This is custom content that appears after all other information generated about the sample
- `override_path` (Optional): If you would like to have a seperate README generate for this file in a different folder within the directory that holds the samples, ex. a folder named `quickstart`, specify that relative path here.
- `override_path` (Optional): If you would like to have a separate README generate for this file in a different folder within the directory that holds the samples, ex. a folder named `quickstart`, specify that relative path here.
If multiple samples have the same override path, the README in that folder will contain info for all those samples.
2 changes: 1 addition & 1 deletion synthtool/sources/templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def language_pretty(input: str) -> str:


def slugify(input: str) -> str:
"""Converts Foo Bar into foo-bar, for use wih anchor links."""
"""Converts Foo Bar into foo-bar, for use with anchor links."""
input = re.sub(r"([() ]+)", "-", input.lower())
return re.sub(r"-$", "", input)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ service DlpService {
option (google.api.method_signature) = "parent";
}

// Creates an InspectTemplate for re-using frequently used configuration
// Creates an InspectTemplate for reusing frequently used configuration
// for inspecting content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates to learn more.
rpc CreateInspectTemplate(CreateInspectTemplateRequest) returns (InspectTemplate) {
Expand Down Expand Up @@ -245,7 +245,7 @@ service DlpService {
option (google.api.method_signature) = "name";
}

// Creates a DeidentifyTemplate for re-using frequently used configuration
// Creates a DeidentifyTemplate for reusing frequently used configuration
// for de-identifying content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
// more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ export class DlpServiceClient {
protos.google.privacy.dlp.v2.ICreateInspectTemplateRequest|null|undefined,
{}|null|undefined>): void;
/**
* Creates an InspectTemplate for re-using frequently used configuration
* Creates an InspectTemplate for reusing frequently used configuration
* for inspecting content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates to learn more.
*
Expand Down Expand Up @@ -1244,7 +1244,7 @@ export class DlpServiceClient {
protos.google.privacy.dlp.v2.ICreateDeidentifyTemplateRequest|null|undefined,
{}|null|undefined>): void;
/**
* Creates a DeidentifyTemplate for re-using frequently used configuration
* Creates a DeidentifyTemplate for reusing frequently used configuration
* for de-identifying content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
* more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ service DlpService {
option (google.api.method_signature) = "parent";
}

// Creates an InspectTemplate for re-using frequently used configuration
// Creates an InspectTemplate for reusing frequently used configuration
// for inspecting content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates to learn more.
rpc CreateInspectTemplate(CreateInspectTemplateRequest) returns (InspectTemplate) {
Expand Down Expand Up @@ -245,7 +245,7 @@ service DlpService {
option (google.api.method_signature) = "name";
}

// Creates a DeidentifyTemplate for re-using frequently used configuration
// Creates a DeidentifyTemplate for reusing frequently used configuration
// for de-identifying content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
// more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates an InspectTemplate for re-using frequently used configuration
* Creates an InspectTemplate for reusing frequently used configuration
* for inspecting content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates to learn more.
*
Expand Down Expand Up @@ -1476,7 +1476,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates a DeidentifyTemplate for re-using frequently used configuration
* Creates a DeidentifyTemplate for reusing frequently used configuration
* for de-identifying content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
* more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ service DlpService {
option (google.api.method_signature) = "parent";
}

// Creates an InspectTemplate for re-using frequently used configuration
// Creates an InspectTemplate for reusing frequently used configuration
// for inspecting content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates to learn more.
rpc CreateInspectTemplate(CreateInspectTemplateRequest) returns (InspectTemplate) {
Expand Down Expand Up @@ -245,7 +245,7 @@ service DlpService {
option (google.api.method_signature) = "name";
}

// Creates a DeidentifyTemplate for re-using frequently used configuration
// Creates a DeidentifyTemplate for reusing frequently used configuration
// for de-identifying content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
// more.
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/nodejs-dlp/src/v2/dlp_service_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates an InspectTemplate for re-using frequently used configuration
* Creates an InspectTemplate for reusing frequently used configuration
* for inspecting content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates to learn more.
*
Expand Down Expand Up @@ -1476,7 +1476,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates a DeidentifyTemplate for re-using frequently used configuration
* Creates a DeidentifyTemplate for reusing frequently used configuration
* for de-identifying content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
* more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates an InspectTemplate for re-using frequently used configuration
* Creates an InspectTemplate for reusing frequently used configuration
* for inspecting content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates to learn more.
*
Expand Down Expand Up @@ -1476,7 +1476,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates a DeidentifyTemplate for re-using frequently used configuration
* Creates a DeidentifyTemplate for reusing frequently used configuration
* for de-identifying content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
* more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function main(parent, backupId, backup) {
* Required. The ID of the backup, which is used as the final component of the
* backup's name.
* This value must be between 1 and 64 characters long, begin with a letter,
* end with a letter or number, and consist of alpha-numeric ASCII characters
* end with a letter or number, and consist of alphanumeric ASCII characters
* or hyphens.
*/
// const backupId = 'abc123'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ service DlpService {
option (google.api.method_signature) = "parent";
}

// Creates an InspectTemplate for re-using frequently used configuration
// Creates an InspectTemplate for reusing frequently used configuration
// for inspecting content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates to learn more.
rpc CreateInspectTemplate(CreateInspectTemplateRequest) returns (InspectTemplate) {
Expand Down Expand Up @@ -245,7 +245,7 @@ service DlpService {
option (google.api.method_signature) = "name";
}

// Creates a DeidentifyTemplate for re-using frequently used configuration
// Creates a DeidentifyTemplate for reusing frequently used configuration
// for de-identifying content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
// more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ export class DlpServiceClient {
protos.google.privacy.dlp.v2.ICreateInspectTemplateRequest|null|undefined,
{}|null|undefined>): void;
/**
* Creates an InspectTemplate for re-using frequently used configuration
* Creates an InspectTemplate for reusing frequently used configuration
* for inspecting content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates to learn more.
*
Expand Down Expand Up @@ -1244,7 +1244,7 @@ export class DlpServiceClient {
protos.google.privacy.dlp.v2.ICreateDeidentifyTemplateRequest|null|undefined,
{}|null|undefined>): void;
/**
* Creates a DeidentifyTemplate for re-using frequently used configuration
* Creates a DeidentifyTemplate for reusing frequently used configuration
* for de-identifying content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
* more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ service DlpService {
option (google.api.method_signature) = "parent";
}

// Creates an InspectTemplate for re-using frequently used configuration
// Creates an InspectTemplate for reusing frequently used configuration
// for inspecting content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates to learn more.
rpc CreateInspectTemplate(CreateInspectTemplateRequest) returns (InspectTemplate) {
Expand Down Expand Up @@ -245,7 +245,7 @@ service DlpService {
option (google.api.method_signature) = "name";
}

// Creates a DeidentifyTemplate for re-using frequently used configuration
// Creates a DeidentifyTemplate for reusing frequently used configuration
// for de-identifying content, images, and storage.
// See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
// more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates an InspectTemplate for re-using frequently used configuration
* Creates an InspectTemplate for reusing frequently used configuration
* for inspecting content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates to learn more.
*
Expand Down Expand Up @@ -1476,7 +1476,7 @@ export class DlpServiceClient {
>
): void;
/**
* Creates a DeidentifyTemplate for re-using frequently used configuration
* Creates a DeidentifyTemplate for reusing frequently used configuration
* for de-identifying content, images, and storage.
* See https://cloud.google.com/dlp/docs/creating-templates-deid to learn
* more.
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/php/php_asset/expected/Asset/owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,5 @@

# Address breaking changes
# We're using a git command for production Asset directory,
# but we emulate tha behavior with a static patch file.
# but we emulate the behavior with a static patch file.
subprocess.run("patch -p2 < ../patch.diff", shell=True)
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
* "projects/12345").
* @param string $destinationParent Name of the GCP Folder or Organization to reparent the target
* resource. The analysis will be performed against hypothetically moving the
* resource to this specified desitination parent. This can only be a Folder
* resource to this specified destination parent. This can only be a Folder
* number (such as "folders/123") or an Organization number (such as
* "organizations/123").
*/
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class AssetServiceGrpcClient extends \Grpc\BaseStub {
/**
* @param string $hostname hostname
* @param array $opts channel options
* @param \Grpc\Channel $channel (optional) re-use channel object
* @param \Grpc\Channel $channel (optional) reuse channel object
*/
public function __construct($hostname, $opts, $channel = null) {
parent::__construct($hostname, $opts, $channel);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ public function analyzeIamPolicyLongrunning(
* "projects/12345").
* @param string $destinationParent Required. Name of the GCP Folder or Organization to reparent the target
* resource. The analysis will be performed against hypothetically moving the
* resource to this specified desitination parent. This can only be a Folder
* resource to this specified destination parent. This can only be a Folder
* number (such as "folders/123") or an Organization number (such as
* "organizations/123").
* @param array $optionalArgs {
Expand Down
Loading