Skip to content

Implements robust break context identification and tests #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2024
Merged

Implements robust break context identification and tests #442

merged 2 commits into from
Sep 2, 2024

Conversation

TobiasWienand
Copy link
Contributor

The two tests succeeded for me. Are any other tests for break context identification interesting?

saelo
saelo reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@saelo saelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also please remove this comment now:

fuzzilli/Sources/Fuzzilli/Compiler/Compiler.swift

Line 449 in aeed429

// TODO remove this comment once the Analyzer bug fixs has been merged. Until then the code in this switch case is buggy.
:)

@saelo saelo merged commit 215d858 into googleprojectzero:main Sep 2, 2024
2 of 3 checks passed
@saelo
Copy link
Collaborator

saelo commented Sep 2, 2024

Thanks!

@TobiasWienand TobiasWienand deleted the feature/ContextAnalyzer-break-context-identification branch April 28, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saelo saelo saelo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiasWienand @saelo