Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aofei
force-pushed
the
avatar
branch
2 times, most recently
from
9a2910f to
7b56761
Compare
Add avatar editing to the profile modal with a dedicated `EditAvatarModal` that lets users crop square images before upload. Extend `PATCH /user` and the frontend user API types to accept `avatar`, then upload the exported PNG to Kodo and save the returned URL immediately from the avatar modal instead of bundling it into the rest of the profile form. Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add avatar editing to the profile modal with a dedicated
EditAvatarModalthat lets users crop square images before upload.Extend
PATCH /userand the frontend user API types to acceptavatar, then upload the exported PNG to Kodo and save the returned URL immediately from the avatar modal instead of bundling it into the rest of the profile form.