-
Notifications
You must be signed in to change notification settings - Fork 9
feat(parser): nested struct/union decl #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
312f3e0
to
0304d12
Compare
4f73aba
to
fb35aa6
Compare
luoliwoshang
commented
Jul 18, 2025
fb35aa6
to
8b8753c
Compare
8b8753c
to
2db7ab9
Compare
81741ca
to
6f5bdcb
Compare
6f5bdcb
to
22a2584
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 27 27
Lines 2747 2747
=======================================
Hits 2313 2313
Misses 391 391
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8541c6c
to
b755157
Compare
b5360c8
to
7dfbe9a
Compare
7dfbe9a
to
aa47de0
Compare
MeteorsLiu
reviewed
Jul 18, 2025
MeteorsLiu
reviewed
Jul 18, 2025
MeteorsLiu
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #507 #517 #514
Problem Statement
Before this fix, the parser had several critical issues with nested named structs/unions:
definitions
postorder traversal
Example Problem Case
Before Fix: Only references to struct b, struct c, struct d, struct e, struct f were generated without their actual
definitions.
After Fix: All nested structs are properly defined with correct dependency ordering.
solution
Expected AST Node Order
For the example above, the correct postorder should be:
[c, d, b, f, e, a]
This ensures that:
All test cases pass, including: