test(esp32c3): run _testgo on emulator

[luoliwoshang]

变更说明

• 增加 ESP32-C3 模拟器测试：复用 cltest.RunFromDir 跑 ./_testgo
• 引入可配置的运行选项与输出过滤（过滤 entry 0x... 之前的启动日志）
• 通过 allow/ignore 列表显式声明当前可运行用例（先放行 ./_testgo/print）

设计要点

• TestRunESP32C3Emulator 风格与 TestRunFromTestgo 保持一致，方便后续扩展到其他嵌入式目标
• 输出过滤逻辑集中在 cltest.FilterEmulatorOutput，便于复用与维护

测试

• 未在本地运行（需要 ESP32-C3 QEMU 环境）

[gemini-code-assist]

Summary of Changes

Hello @luoliwoshang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the testing framework for embedded systems, particularly for the ESP32-C3 microcontroller. It introduces dedicated emulator tests, refines the build and test execution process with flexible configuration options and output filtering, and updates core library configurations. These changes aim to enhance the reliability and maintainability of embedded software development by providing a more robust and automated testing environment.

Highlights

• ESP32-C3 Emulator Coverage: Added a new 'hello world' test specifically for the ESP32-C3 target, designed to run within an emulator environment to ensure basic functionality and output.
• Enhanced Test Runner: The cltest.RunFromDir function has been extended with new options, WithRunConfig and WithOutputFilter, allowing for custom build configurations and the ability to filter emulator boot logs before comparing test output.
• New ESP32-C3 Target Definition: A new esp32c3-basic.json target has been introduced, defining the specific configurations and emulator command for the ESP32-C3 RISC-V architecture.
• Newlib Update and Refactoring: The Newlib ESP32 configuration has been updated to 'patch5', and the RISC-V compile groups have been refactored to include a separate libsemihost group, improving the organization and handling of semihosting functionalities.
• Firmware Image Creation Adjustment: The firmware image creation logic for ESP devices has been updated to conditionally add 4KB padding only for ESP32 (Xtensa) chips, removing it for ESP32-C3 (RISC-V) as its bootloader starts at 0x0.
• GitHub Actions for Embedded Dependencies: A new GitHub Action (setup-embed-deps) has been added to automate the installation of necessary embedded dependencies, including SDL2 and ESP32 RISC-V QEMU, for CI/CD environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (3)
  • .github/workflows/go.yml
  • .github/workflows/install-esp-qemu.sh
  • .github/workflows/llgo.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds emulator test coverage for the ESP32-C3 target. The changes include adding a new esp32c3-basic target for emulation, extending the cltest helpers with support for custom run configurations and output filtering, and adding a new test case that runs on the QEMU emulator. The refactoring of the ESP32-C3 target configuration and the newlib build process to separate semihosting logic are good improvements for maintainability. My feedback includes a minor performance improvement for the new test helper.

[gemini-code-assist]

Compiling a regular expression on every function call is inefficient, especially since this function might be called in a loop during tests. It's better to compile it once at the package level and reuse the compiled object.

Please remove this line and define entryPattern as a package-level variable:

var entryPattern = regexp.MustCompile(`^entry 0x[0-9a-fA-F]+$`)

[xgopilot]

The regex is compiled on every function call. Since this filter is invoked for each test case, consider moving the pattern to a package-level variable:

Suggested change

	lines := strings.Split(output, "\n")
	var entryPattern = regexp.MustCompile(`^entry 0x[0-9a-fA-F]+$`)
	// FilterEmulatorOutput strips emulator boot logs by returning output after "entry 0x...".
	func FilterEmulatorOutput(output string) string {
	lines := strings.Split(output, "\n")

[xgopilot]

nit: The version string uses underscores but the release tag uses hyphens. A brief comment would help prevent future maintainers from accidentally "fixing" this discrepancy:

Suggested change

	# Download URL
	# Note: VERSION uses underscores per Espressif's filename convention,
	# while the release tag uses hyphens.
	VERSION="esp_develop_9.2.2_20250817"

[xgopilot]

Code Review Summary

This PR adds comprehensive ESP32-C3 emulator test coverage with well-structured CI infrastructure. The functional options pattern in RunFromDir is idiomatic Go, and the JSON inheritance for target configs is clean.

One improvement to address:

• Move entryPattern regex to package level in FilterEmulatorOutput to avoid recompiling on each call.

Optional enhancement:

• Consider adding checksum verification in install-esp-qemu.sh for enhanced supply chain security (not blocking).

Overall, solid implementation with good test coverage for embedded targets.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (f6337d4) to head (4d84e8d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   91.01%   91.01%   -0.01%     
==========================================
  Files          45       45              
  Lines       11971    11966       -5     
==========================================
- Hits        10896    10891       -5     
  Misses        899      899              
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.