feat: [#726] Add HTTP server and client telemetry instrumentation [5] #1326
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,7 +156,7 @@ func getHandlers(config config.Config, json foundation.Json, channel string) ([] | |
| handlers = append(handlers, HandlerToSlogHandler(logger.NewConsoleHandler(config, json, level, formatter))) | ||
| } | ||
| case log.DriverOtel: | ||
| logLogger := telemetrylog.NewTelemetryChannel(config) | ||
|
||
| handler, err := logLogger.Handle(channelPath) | ||
| if err != nil { | ||
| return nil, err | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| package http | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
|
|
||
| "github.com/goravel/framework/contracts/http" | ||
| ) | ||
|
|
||
| // Filter allows excluding specific requests from being traced. | ||
| type Filter func(ctx http.Context) bool | ||
|
Contributor
There was a problem hiding this comment. According to the code, the specific requests won't be traced when the filter returns false. I think it's a bit confusing here. The specific requests should be traced when the filter returns false based on the annotation. 
Member
Author
There was a problem hiding this comment. updated the annotation |
||
|
|
||
| // SpanNameFormatter allows customizing the span name. | ||
| type SpanNameFormatter func(route string, ctx http.Context) string | ||
|
|
||
| // Option applies configuration to the server instrumentation. | ||
| type Option func(*ServerConfig) | ||
|
|
||
| // ServerConfig maps to "telemetry.instrumentation.http_server". | ||
| type ServerConfig struct { | ||
| Enabled bool `mapstructure:"enabled"` | ||
krishankumar01 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ExcludedPaths []string `mapstructure:"excluded_paths"` | ||
| ExcludedMethods []string `mapstructure:"excluded_methods"` | ||
| Filters []Filter `mapstructure:"-"` | ||
| SpanNameFormatter SpanNameFormatter `mapstructure:"-"` | ||
| MetricAttributes []attribute.KeyValue `mapstructure:"-"` | ||
| } | ||
|
|
||
| func WithFilter(f Filter) Option { | ||
| return func(c *ServerConfig) { | ||
| c.Filters = append(c.Filters, f) | ||
| } | ||
| } | ||
|
|
||
| func WithSpanNameFormatter(f SpanNameFormatter) Option { | ||
| return func(c *ServerConfig) { | ||
| c.SpanNameFormatter = f | ||
| } | ||
| } | ||
|
|
||
| func WithMetricAttributes(attrs ...attribute.KeyValue) Option { | ||
| return func(c *ServerConfig) { | ||
| c.MetricAttributes = append(c.MetricAttributes, attrs...) | ||
| } | ||
| } | ||
|
|
||
| func defaultSpanNameFormatter(route string, ctx http.Context) string { | ||
| return fmt.Sprintf("%s %s", ctx.Request().Method(), route) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the route registration to the end, because if a user registers any gRPC stats handler or interceptors after calling
routes.Grpc()(since in this file we usually callfacades.Grpc().Server()), they will be ignored as the server is initialized only once ingrpc/application.go.