Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ID method to auth #616

Merged
merged 14 commits into from
Sep 4, 2024
Merged

feat: Add ID method to auth #616

merged 14 commits into from
Sep 4, 2024

Conversation

milwad-dev
Copy link
Contributor

@milwad-dev milwad-dev commented Aug 29, 2024

πŸ“‘ Description

// Laravel
Auth::id();
facades.Auth(ctx).Id()

@coderabbitai summary

βœ… Checks

  • Added test cases for my code

@milwad-dev milwad-dev requested a review from a team as a code owner August 29, 2024 18:47
Copy link
Contributor

coderabbitai bot commented Aug 29, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • πŸš€ Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@milwad-dev milwad-dev changed the title [1.x] Add ID method to auth feat: Add ID method to auth Aug 29, 2024
@milwad-dev milwad-dev marked this pull request as draft August 29, 2024 18:50
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 69.95%. Comparing base (f2f6637) to head (211dd14).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   69.96%   69.95%   -0.02%     
==========================================
  Files         184      184              
  Lines       11252    11267      +15     
==========================================
+ Hits         7873     7882       +9     
- Misses       2800     2815      +15     
+ Partials      579      570       -9     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

auth/auth.go Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot previously approved these changes Sep 2, 2024
@milwad-dev
Copy link
Contributor Author

All tests passed, but I don't know why Mockery failed!

@milwad-dev milwad-dev marked this pull request as ready for review September 2, 2024 23:44
@devhaozi
Copy link
Member

devhaozi commented Sep 3, 2024

All tests passed, but I don't know why Mockery failed!

Because no permission, you can run mockery localy and commit changes.

@devhaozi devhaozi closed this Sep 4, 2024
@devhaozi devhaozi reopened this Sep 4, 2024
@devhaozi devhaozi enabled auto-merge (squash) September 4, 2024 13:56
@devhaozi devhaozi merged commit 388451e into goravel:master Sep 4, 2024
8 of 10 checks passed
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Sep 4, 2024

Great PR, thanks! Added you to the contributor list.

@milwad-dev
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants