feat: [#462] Custom Log Channel cannot take values from some functions by krishankumar01 · Pull Request #640 · goravel/framework

krishankumar01 · 2024-09-11T17:43:06Z

📑 Description

Closes goravel/goravel#462

@coderabbitai summary

✅ Checks

Added test cases for my code

coderabbitai · 2024-09-11T17:43:15Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: `7581f6d`	Previous: `40b9e2a`	Ratio
`BenchmarkFile_ReadWrite`	`315962` ns/op 1800 B/op 21 allocs/op	`169668` ns/op 1800 B/op 21 allocs/op	`1.86`
`BenchmarkFile_ReadWrite - ns/op`	`315962` ns/op	`169668` ns/op	`1.86`

This comment was automatically generated by workflow using github-action-benchmark.

codecov · 2024-09-11T17:53:31Z

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.

Project coverage is 70.06%. Comparing base (551f30f) to head (aafe41a).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
log/entry.go	37.50%	10 Missing ⚠️
log/logrus_writer.go	61.90%	4 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   69.94%   70.06%   +0.11%     
==========================================
  Files         184      184              
  Lines       11296    11331      +35     
==========================================
+ Hits         7901     7939      +38     
+ Misses       2818     2810       -8     
- Partials      577      582       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devhaozi

LGTM

hwbrzzl

The optimization is basically good, please add some test cases for them. And please move the session optimization to another PR, there is a lot of session logic in this PR, and it's unsuitable to add them here.

hwbrzzl · 2024-09-13T14:21:22Z

log/logrus_writer.go

@@ -365,10 +366,48 @@ func (h *Hook) Levels() []logrus.Level {
 }

 func (h *Hook) Fire(entry *logrus.Entry) error {


Could you add a test case for this function?

…462

hwbrzzl

Great PR 👍

add methods to entry

d4d2715

krishankumar01 requested a review from a team as a code owner September 11, 2024 17:43

Merge branch 'master' into kkumar-gcc/#462

7581f6d

chore: update mocks

46066d3

krishankumar01 closed this Sep 11, 2024

krishankumar01 reopened this Sep 11, 2024

github-actions bot reviewed Sep 11, 2024

View reviewed changes

devhaozi previously approved these changes Sep 12, 2024

View reviewed changes

krishankumar01 dismissed devhaozi’s stale review via 26ebab4 September 12, 2024 08:13

krishankumar01 requested review from devhaozi and hwbrzzl September 12, 2024 08:16

krishankumar01 closed this Sep 12, 2024

krishankumar01 reopened this Sep 12, 2024

hwbrzzl reviewed Sep 12, 2024

View reviewed changes

krishankumar01 force-pushed the kkumar-gcc/#462 branch from 06f0ff0 to 46066d3 Compare September 12, 2024 17:51

hwbrzzl reviewed Sep 13, 2024

View reviewed changes

krishankumar01 and others added 3 commits September 13, 2024 23:20

Merge branch 'master' into kkumar-gcc/#462

33cdaff

add test cases for log

76cc71f

Merge remote-tracking branch 'origin/kkumar-gcc/#462' into kkumar-gcc/#…

aafe41a

…462

hwbrzzl approved these changes Sep 14, 2024

View reviewed changes

krishankumar01 merged commit f5c6941 into master Sep 14, 2024

krishankumar01 deleted the kkumar-gcc/#462 branch September 14, 2024 04:20

almas-x added a commit that referenced this pull request Mar 26, 2025

feat: [#640] Optimize console ctx.Confirm method

eba920f

almas-x added a commit that referenced this pull request Mar 26, 2025

feat: [#640] Optimize console ctx.Confirm method (#971)

7801f1d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [#462] Custom Log Channel cannot take values from some functions#640

feat: [#462] Custom Log Channel cannot take values from some functions#640
krishankumar01 merged 6 commits intomasterfrom
kkumar-gcc/#462

krishankumar01 commented Sep 11, 2024

Uh oh!

coderabbitai bot commented Sep 11, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot left a comment

Uh oh!

codecov bot commented Sep 11, 2024 •

edited

Loading

Uh oh!

devhaozi left a comment

Uh oh!

hwbrzzl left a comment

Uh oh!

hwbrzzl Sep 13, 2024

Uh oh!

hwbrzzl left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

		@@ -365,10 +366,48 @@ func (h *Hook) Levels() []logrus.Level {
		}

		func (h Hook) Fire(entry logrus.Entry) error {

Conversation

krishankumar01 commented Sep 11, 2024

📑 Description

✅ Checks

Uh oh!

coderabbitai bot commented Sep 11, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

codecov bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

devhaozi left a comment

Choose a reason for hiding this comment

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Sep 11, 2024 •

edited

Loading