Skip to content

Conversation

@russellbanks
Copy link

@russellbanks russellbanks commented Jul 7, 2022

This pull request adds a workflow that automatically publishes GDLauncher to WinGet every release. It would replace GDLauncher being automated by vedantmgoyal2009/winget-pkgs-automation (This workflow is made by the same person that made winget-pkgs-automation). Please do not merge this pull request without reading the below and making the required changes (The token part is the important bit) :)

  • installers-regex: '\.exe$'

This will include all .exe files in the assets of the latest GDLauncher release (GDLauncher-win-setup.exe) in the pull request.


  • token: ${{ secrets.WINGET_TOKEN }}

This is the bit that will require action from the person whose account will be used for the pull requests (a member of the gorila-devs GitHub organisation). This is a GitHub token with which the action will authenticate with GitHub and create a pull request on the winget-pkgs repository.

To do this, you will need to:

  1. Create a Personal Access Token (PAT) with public_repo scope.

image

  1. Create a repository secret containing the token. Super important: call this token: WINGET_TOKEN.
    See using encrypted secrets in a workflow for more details.

Finally, a fork of winget-pkgs needs to be created under the gorilla-devs organisation. Please do not delete the fork after a pull request has been merged as the action will use that fork for making a branch and merging it with the upstream winget-pkgs repository on every GDLauncher release.

If you would like to read about this action further, the source code and documentation are here.

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Russell Banks
❌ russellbanks


Russell Banks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Eskaan
Copy link
Collaborator

Eskaan commented Jul 7, 2022

Won't run checks as they are destined for failure.

@vedantmgoyal9
Copy link

@Eskaan can you please review and merge?

@Eskaan
Copy link
Collaborator

Eskaan commented Jan 18, 2023

I am going through everything atm. One after another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants