Token from context

[FlorianLoch]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Go Version Update
• Dependency Update

Description

In order for csrf to play nicely with libraries like huma is seems beneficial to be able to retrieve a token not just from a http.Request but also straight from the context.Context.
This avoids workarounds like creating a dummy request just to pass along the context.
Additionally, it feels more natural to me to pass the actually required value (with is a context.Context) instead of the value wrapped with something else that is not really required for retrieving the token.

Related Tickets & Documents

n. a.

• Related Issue #
• Closes #

Added/updated tests?

• Yes
• No, and this is why: changes should be covered by existing tests already, adjustment very minor
• I need help with writing tests

Run verifications and test

• make verify is passing
• make test is passing

[FlorianLoch]

Requesting review from @gorilla/pull-request-reviewers. :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (a009743) to head (b6bb886).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   90.93%   91.03%   +0.10%     
==========================================
  Files           5        5              
  Lines         353      357       +4     
==========================================
+ Hits          321      325       +4     
  Misses         25       25              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AlexVulaj]

@jaitaiwan this looks good to me - mind giving it a quick second look and merging if you're happy with it as well? In summary, it makes it so a token can be fetched directly from a context instead of having to wrap it in an http.Request.

[FlorianLoch]

Hi there,
could we please run the checks again as I cannot retrieve the logs anymore and running golangci-lint locally does not yield issues for me - but the set of checks performed depends massively on the version of golangci-lint... So a rerun would be great :)

[jaitaiwan]

I’m on mobile right now but I can’t see an easy way to re run. Will sort it on desktop soon.

[FlorianLoch]

Any update on this? ;)