Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/action 1 #3

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Feature/action 1 #3

wants to merge 19 commits into from

Conversation

goutamdh
Copy link
Owner

Overview

REPLACE THIS with what's in the PR. Is there anything the reviewer should know?

Reviewee Checklist

Complete this checklist if you are submitting the PR.

  • The PR is named correctly.
    • The ticket number should be in PR title. For Release -> Master something else...
  • The PR is merging to correct branch.
  • The PR has been checked out and confirmed to run locally.
  • Components impacted by shared file changes have been tested to ensure there are no breaking changes.
  • The code is readable.
    • Checked for too many nested conditions.
    • Functions and variables named appropriately. (eg. Avoid use of acronyms)
  • There are no commented-out blocks of code.
    • Temporarily commented-out code is an exception. It should be noted.

Reviewer Checklist

Complete this checklist if you are the reviewer.

  • The PR is named correctly.
    • The ticket number should be in PR title. For Release -> Master something else...
  • The PR is merging to correct branch?
  • There are no changes in this PR that are outside the scope of the ticket.
  • The PR has been checked out and confirmed to run locally.
  • Components impacted by shared file changes have been tested to ensure there are no breaking changes.
  • The code is readable.
    • Checked for too many nested conditions.
    • Functions and variables named appropriately. (eg. Avoid use of acronyms)
  • There are no commented-out blocks of code.
    • Temporarily commented-out code is an exception. It should be noted.

Merge Instructions

When merging PRs to Integration and Master/Main/Trunk, use the Squash merge option.

Tips

  • Press "." to open this PR in a browser-based vscode.

FOR CONFLUENCE

Labels

Use labels to signal the state of Pull Requests.

@goutamdh goutamdh self-assigned this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant