Skip to content

feat: add covi box #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

feat: add covi box #484

merged 1 commit into from
Jul 10, 2025

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Jul 5, 2025

CoverageInformationBox (covi) is in ISO/IEC 23090-2:2023 Section 7.6.6

There is also an equivalent image property (ISO/IEC 23090-2:2023 Section 7.9.8).

CoverageInformationBox (covi) is in ISO/IEC 23090-2:2023 Section 7.6.6

There is also an equivalent image property (ISO/IEC 23090-2:2023 Section 7.9.8).
@bradh
Copy link
Contributor Author

bradh commented Jul 5, 2025

The test failure does not appear related:

File .cache/files/published/nalu/l-hevc/shvc_hvc2_single_track.mp4 does not exist, but is listed in metadata.

I don't see anything changed in the conformance files, so not sure where that came from

@DenizUgur
Copy link
Member

I don't know either, the test suite randomly fails.

@bradh
Copy link
Contributor Author

bradh commented Jul 5, 2025

I don't know either, the test suite randomly fails.

Thanks for the restart in any case.

@DenizUgur
Copy link
Member

Could you post a screenshot from the file reader demo? Or provide a file with covi?

@bradh
Copy link
Contributor Author

bradh commented Jul 10, 2025

Here is a screenshot:

image

That uses the Garage_qp28.mp4 sample from omaf.js - that has most of the boxes I'm adding.

@DenizUgur
Copy link
Member

Thanks. I'm not a big fan of this toString stuff but we do it as well so I'm not complaining. Hopefully we'll refactor these stuff in the future. I'll merge your other PR and this though.

@DenizUgur DenizUgur merged commit 5318a1a into gpac:main Jul 10, 2025
6 of 7 checks passed
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bradh bradh deleted the covi_2025-06-30 branch July 10, 2025 21:23
@bradh
Copy link
Contributor Author

bradh commented Jul 11, 2025

I'm not a big fan of this toString stuff but we do it as well so I'm not complaining.

It would be nice if javascript would just show the nested structure, but writing toString() {...} seems better than seeing [Object, Object, Object] for cases where its hard to map to a different structure (e.g. splitting into array of offsets and an array of sizes).

@DenizUgur
Copy link
Member

Yeah, I agree. We need to visualize the contents of boxes like this for sure, especially for a box like this. I guess I meant that currently the library has to provide this function so that file reader demo can work "better". At some point that has to be separated.

But this is way off topic. Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants