Skip to content

fix: format week number with numerals #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025
Merged

Conversation

gpbl
Copy link
Owner

@gpbl gpbl commented May 4, 2025

This PR fixes the week numbers not being properly formatted when using the numerals prop:

Screen Shot 2025-05-04 at 14 59 25

  • Updated formatWeekNumber to use DateLib and formatNumber
  • Added more tests

Result:

Screen Shot 2025-05-04 at 14 59 53

@gpbl gpbl requested a review from rodgobbi May 4, 2025 20:37
Repository owner deleted a comment May 10, 2025
Repository owner deleted a comment May 10, 2025
@gpbl gpbl merged commit 3fcb74d into main May 10, 2025
20 checks passed
@gpbl gpbl deleted the gpbl/fix-numerals-weeknumber branch May 10, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant