Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid XML namespace #110

Merged
merged 1 commit into from
May 14, 2021

Conversation

spideyfusion
Copy link
Contributor

Although it's possible to view the web page contents of the referenced namespace, the only valid name for the namespace is http://www.w3.org/1999/xhtml.

The XML namespace specification is clear when a namespace reference is considered identical:

[Definition: The two URIs are treated as strings, and they are identical if and only if the strings are identical, that is, if they are the same sequence of characters. ] The comparison is case-sensitive, and no %-escaping is done or undone.


The error is evident from the GSC (Google Search Console) when it analyzes a sitemap generated by the library:

Your Sitemap or Sitemap index file doesn't properly declare the namespace. Expected: http://www.w3.org/1999/xhtml Found: https://www.w3.org/1999/xhtml

@peter-gribanov peter-gribanov self-assigned this May 14, 2021
@coveralls
Copy link

coveralls commented May 14, 2021

Coverage Status

Coverage remained the same at 96.925% when pulling e13121b on spideyfusion:fix-invalid-namespace into ddc67fb on gpslab:2.x.

@peter-gribanov
Copy link
Member

Good job. Thanks 👍

@peter-gribanov peter-gribanov merged commit aecd491 into gpslab:2.x May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants