Upgrade all demos and guides to 25.0.0.
#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fniephaus
requested review from
gilles-duboscq,
jirkamarsik,
steve-s,
timfel and
woess
oracle-contributor-agreement
bot
added
the
OCA Verified
fniephaus
force-pushed
the
fniephaus/25.0
branch
from
cb590b9 to
6720c11
Compare
woess
approved these changes
Sep 23, 2025
gilles-duboscq
approved these changes
Sep 23, 2025
steve-s
approved these changes
Sep 24, 2025
jirkamarsik
reviewed
Sep 24, 2025
Member
jirkamarsik
left a comment
jirkamarsik
left a comment
There was a problem hiding this comment.
GraalWasm changes look good, thanks!
| public static void main(String[] args) throws IOException { | ||
| // Find the WebAssembly module resource | ||
| URL wasmFile = App.class.getResource("floyd.wasm"); | ||
| Source source = Source.newBuilder("wasm", wasmFile).name("example").build(); |
Member
There was a problem hiding this comment.
We can drop .name("example") as the Source name is no longer used when reading the exports.
| </executions> | ||
| <configuration> | ||
| <mainClass>com.example.App</mainClass> | ||
| </configuration> |
Member
There was a problem hiding this comment.
I always get tripped up by <pluginManagement> vs <plugins>. If I understand correctly, in <pluginManagement> we should only have the version, and the configuration should live in <plugins>, as in graalwasm-embed-c-code-guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all demos to the new 25.0.0 releases of GraalPy, GraalJS, GraalWasm, and Espresso. This also requires updates for Gradle to run on JDK 25, as well as some adjustments for how Wasm modules are now instantiated on GraalWasm. Review commit-by-commit.