-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a settings
link to the footer with i18n options & pwa instructions
#10254
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/21aa7172558d2278428bf1cf38517eca3ce1b1dd/gradio-5.9.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@21aa7172558d2278428bf1cf38517eca3ce1b1dd#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/21aa7172558d2278428bf1cf38517eca3ce1b1dd/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/21aa7172558d2278428bf1cf38517eca3ce1b1dd/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
settings
link to the footersettings
link to the footer with i18n options & pwa instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and it LGTM, thanks!
where are all the json language changes coming from? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! left some visual comments
Done! |
Adds a new Settings link in the footer:
Clicking on the Settings link opens up a page that allows toggling the theme, localization, and pwa installation instructions:
While I was at it, I also went through and filled in many of the missing entries in our i18n translation files (thanks Claude!) in 35f8706.
Closes: #655, Closes: #785