Skip to content

use a real browser environment for unit tests #11214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

use a real browser environment for unit tests #11214

wants to merge 5 commits into from

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented May 16, 2025

This PR switches our test runner to use a browser at all times. The speeds are pretty good and will simplify testing.

This paves the way for further improvements coming shortly.

Just a few tests left to fix.

@pngwn pngwn changed the title switch text runner switch test runner May 16, 2025
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented May 16, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/4e7574602b302ce21022f0f7f8853816b8f3ad0d/gradio-5.29.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4e7574602b302ce21022f0f7f8853816b8f3ad0d#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/4e7574602b302ce21022f0f7f8853816b8f3ad0d/gradio-client-1.14.2.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/4e7574602b302ce21022f0f7f8853816b8f3ad0d/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented May 16, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/image minor
@gradio/statustracker minor
@gradio/wasm minor
@self/spa minor
@self/tootils minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

use a real browser environment for unit tests

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn pngwn changed the title switch test runner use a real browser environment for unit tests May 16, 2025
@43081j
Copy link

43081j commented May 16, 2025

if you update the workflow to run npx playwright install, it should at least get it running

you probably don't wanna do it in an npm script since locally we only need to set it up one time

@pngwn
Copy link
Member Author

pngwn commented May 16, 2025

@43081j hero

@pngwn
Copy link
Member Author

pngwn commented May 16, 2025

Tests are failing but they run in about 25 seconds. Which is about the same as before.

Looks pretty good from a practical point of view so I'll finish this off and we should have an easier time testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants