-
Notifications
You must be signed in to change notification settings - Fork 2.9k
use a real browser environment for unit tests #11214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/4e7574602b302ce21022f0f7f8853816b8f3ad0d/gradio-5.29.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4e7574602b302ce21022f0f7f8853816b8f3ad0d#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/4e7574602b302ce21022f0f7f8853816b8f3ad0d/gradio-client-1.14.2.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/4e7574602b302ce21022f0f7f8853816b8f3ad0d/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
if you update the workflow to run you probably don't wanna do it in an npm script since locally we only need to set it up one time |
@43081j hero |
Tests are failing but they run in about 25 seconds. Which is about the same as before. Looks pretty good from a practical point of view so I'll finish this off and we should have an easier time testing. |
This PR switches our test runner to use a browser at all times. The speeds are pretty good and will simplify testing.
This paves the way for further improvements coming shortly.
Just a few tests left to fix.