Skip to content

Fix zerogu-guide #11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 12, 2025
Merged

Fix zerogu-guide #11370

merged 11 commits into from
Jun 12, 2025

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jun 11, 2025

Description

Closes: #10914

Rewrote the guide to use the z-ip-token header after the load event.

2025-06-10_18-45-58.mp4

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 11, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/98ce089d0fda7eee5f7b41491777131e4ebebc61/gradio-5.33.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@98ce089d0fda7eee5f7b41491777131e4ebebc61#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/98ce089d0fda7eee5f7b41491777131e4ebebc61/gradio-client-1.15.2.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/98ce089d0fda7eee5f7b41491777131e4ebebc61/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 11, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix zerogu-guide

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review June 11, 2025 17:34
@freddyaboulton freddyaboulton requested a review from hysts June 11, 2025 17:36
@freddyaboulton freddyaboulton changed the title Fix zerogu-guide + also pass zero-gpu-token Fix zerogu-guide Jun 11, 2025
@abidlabs abidlabs self-requested a review June 11, 2025 18:32
@@ -24,40 +24,26 @@ How to do this will be explained in the following section.

### Avoiding Rate Limits

When a user visits the page, we will extract their token from the `X-IP-Token` header of the incoming request.
We will use this header value in all subsequent client requests.
When a user pressed enter in the textbox, we will extract their token from the `X-IP-Token` header of the incoming request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When a user pressed enter in the textbox, we will extract their token from the `X-IP-Token` header of the incoming request.
When a user presses enter in the textbox, we will extract their token from the `X-IP-Token` header of the incoming request.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look reasonable, perhaps @hysts can also just confirm

Copy link
Collaborator

@hysts hysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

prompt.submit(text_to_image, [client, prompt], [image])

demo.load(set_client_for_session, None, client)
prompt.submit(text_to_image, [prompt], [image])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could you add demo.launch()? Looks like it was left out from the beginning.

@freddyaboulton freddyaboulton enabled auto-merge (squash) June 12, 2025 18:09
@freddyaboulton freddyaboulton merged commit 992f84b into main Jun 12, 2025
23 of 24 checks passed
@freddyaboulton freddyaboulton deleted the 10914-fix-zero-gpu-guide branch June 12, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling ZeroGPU Spaces using gradio-client from another Space doesn't work when SSR is enabled
4 participants