Remove certain parts of the pod security context #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble on certain platforms. Signed-off-by: Pete Wall <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes certain pod security context settings from the alloy-operator Helm chart that have caused compatibility issues on certain platforms. The chart version is bumped from 0.3.15 to 0.4.0.
Changes:
- Removed default values for
fsGroup,runAsGroup,runAsUser, andseccompProfilefrompodSecurityContext, keeping onlyrunAsNonRoot: true - Updated chart version from 0.3.15 to 0.4.0 across all files
- Removed the
securityContext/noUserOrGroupexample documentation since these settings are no longer defaults
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/alloy-operator/values.yaml | Removed fsGroup, runAsGroup, runAsUser, and seccompProfile from podSecurityContext defaults |
| charts/alloy-operator/values.schema.json | Reordered runAsNonRoot property but kept all security context properties in schema to allow user overrides |
| charts/alloy-operator/Chart.yaml | Bumped version to 0.4.0 |
| charts/alloy-operator/CHANGELOG.md | Added entry for version 0.4.0 documenting the security context changes |
| charts/alloy-operator/README.md | Updated version badge to 0.4.0 and updated podSecurityContext documentation |
| charts/alloy-operator/docs/examples/*/output.yaml | Updated all example outputs to reflect version 0.4.0 and removed security context settings |
| charts/alloy-operator/docs/examples/securityContext/noUserOrGroup/* | Deleted example files as these settings are no longer defaults |
| charts/sample-parent-chart/Chart.yaml | Updated dependency version to 0.4.0 |
| charts/sample-parent-chart/Chart.lock | Updated dependency version, digest, and generation timestamp |
| charts/sample-parent-chart/charts/alloy-operator-0.4.0.tgz | Added new packaged chart version |
| README.md | Updated version table to show Alloy Operator 0.4.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings have caused trouble on certain platforms.