Skip to content

build-image: add rust toolchains #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

build-image: add rust toolchains #2921

merged 1 commit into from
Mar 10, 2025

Conversation

korniltsev
Copy link
Contributor

PR Description

  • Add rustup and add aarch64-unknown-linux-musl x86_64-unknown-linux-musl targets
  • Add cmake which is required for zydis crate

Which issue(s) this PR fixes

This is a preparation for
#2920

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@korniltsev korniltsev requested a review from a team as a code owner March 6, 2025 12:55
@ptodev
Copy link
Contributor

ptodev commented Mar 6, 2025

I had a look at the other PR but I'm still not sure what will be built in Rust?

@korniltsev
Copy link
Contributor Author

I had a look at the other PR but I'm still not sure what will be built in Rust?

@ptodev
In the mentioned alloy pr, this makefile

https://github.com/grafana/alloy/pull/2920/files#diff-894459df3255ab94009d75df8b985ff61206757da4a45489b48bfdbac55949ecR16

Calls into this makefile

https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/main/Makefile#L87

Which builds this library
https://github.com/open-telemetry/opentelemetry-ebpf-profiler/tree/main/rust-crates

@ptodev ptodev merged commit 601a049 into main Mar 10, 2025
35 checks passed
@ptodev ptodev deleted the build-image-rust-toolchains branch March 10, 2025 09:19
towolf pushed a commit to towolf/alloy that referenced this pull request Apr 2, 2025
towolf pushed a commit to towolf/alloy that referenced this pull request Apr 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants