enhancement: add support for extra query matchers in loki.rules.kubernetes #3373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
support-extra-labels-on-loki-rule-queries
branch
from
5fb36c2 to
786a71f
Compare
Merged
2 tasks
clayton-cornell
added
the
type/docs
docs/sources/reference/components/loki/loki.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/loki/loki.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/loki/loki.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/loki/loki.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
QuentinBisson
commented
Apr 17, 2025
Co-authored-by: Clayton Cornell <[email protected]>
Contributor
Author
|
Thank you for the review @clayton-cornell :) |
Contributor
|
Over to @grafana/grafana-agent-maintainers fr a code review now :-) |
wildum
reviewed
May 13, 2025
Contributor
wildum
left a comment
wildum
left a comment
There was a problem hiding this comment.
Thanks for bringing this change to loki.rules.kubernetes. I only have two small comments about the error handling part of the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The goal is to allow loki.rules.kubernetes to add extra matchers to queries to align with this PR #1773 that was done for mimir.rules.kubernetes.
Which issue(s) this PR fixes
Notes to the Reviewer
I tried to copy the same structure as the code in the mimir.rules.kubernetes component changing mostly the parsing code (using logql instead) which was quite fun to do.
There might be similarities between the 2 code bases that might require some code sharing in places but with the upcoming PRs that I opened for the
mimir.rules.kubernetescomponent (#3270 and #3175), I feel like it might be better to refactor this later one.PR Checklist