-
Notifications
You must be signed in to change notification settings - Fork 350
Update otel deps from v0.125.0 to v0.126.0 #3781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If we update the OTel version, the main There's a PR in-progress that updates these files to |
@@ -81,7 +83,13 @@ You can use the following blocks with `otelcol.auth.oauth2`: | |||
The `tls` block configures TLS settings used for connecting to the token client. | |||
If the `tls` block isn't provided, TLS won't be used for communication. | |||
|
|||
{{< docs/shared lookup="reference/components/otelcol-tls-client-block.md" source="alloy" version="<ALLOY_VERSION>" >}} | |||
\{\{< docs/shared lookup="reference/components/otelcol-tls-client-block.md" source="alloy" version="<ALLOY_VERSION>" >\}\} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something broke here? We don't need to escape the curly brackets... Same throughout the topics here... copy pasted the error?
| Block | Description | Required | | ||
|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------|----------| | ||
| [`histogram`][histogram] | Configures the histogram derived from spans durations. | yes | | ||
| `histogram` > [`dimension`][dimension] | Span event attributes to add as dimensions to the duration metric, _on top of_ the default ones and the ones configured in the top-level `dimension` block | no | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @clayton-cornell - as this block is nested, I wanted it by its parent, however the parent is required and it is not. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. There are cases like that scattered throughout the component docs. I clustered them exactly like this. This makes sense.
The only relevant thing I didn't pull in from the otel changelog was the datadogreceiver's 128bit traceID support. This seems like a great thing to bring in, but I was just triaging an issue with it earlier this week and want to be sure it's ready for production use before we enable it by default, as we don't have a pattern right now for supporting otelcol feature flags being configured by the user.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, so giving it LGTM % comments
docs/sources/reference/components/otelcol/otelcol.exporter.kafka.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-tls-tpm-block.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-tls-tpm-block.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise good to go.
| Block | Description | Required | | ||
|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------|----------| | ||
| [`histogram`][histogram] | Configures the histogram derived from spans durations. | yes | | ||
| `histogram` > [`dimension`][dimension] | Span event attributes to add as dimensions to the duration metric, _on top of_ the default ones and the ones configured in the top-level `dimension` block | no | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. There are cases like that scattered throughout the component docs. I clustered them exactly like this. This makes sense.
| `histogram` > [`explicit`][explicit] | Configuration for a histogram with explicit buckets. | no | | ||
| `histogram` > [`exponential`][exponential] | Configuration for a histogram with exponential buckets. | no | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move these two up with the parent histogram
block as well.
PR Description
The aim of this PR is upgrading otel dependencies version step by step. The renovate upgrade to v0.127.0 fails. The issue there is not straight forward to fix. It was caused by the change open-telemetry/opentelemetry-collector#12996 in v0.127.0.
Upgrading to v0.126.0 doesn't contain that change, and upgrading to it is pretty easy. Upgrading to v0.126.0 will make the next upgrading to v0.127.0 a bit easier as well
For Reviewers
open-telemetry/opentelemetry-collector-contrib#39767 - change in contrib related to the datadog exporter metrics config
instrumentation_scope_metadata_as_tags
changed default value totrue
PR Checklist