Skip to content

Update otel deps from v0.125.0 to v0.126.0 #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 10, 2025

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Jun 5, 2025

PR Description

The aim of this PR is upgrading otel dependencies version step by step. The renovate upgrade to v0.127.0 fails. The issue there is not straight forward to fix. It was caused by the change open-telemetry/opentelemetry-collector#12996 in v0.127.0.
Upgrading to v0.126.0 doesn't contain that change, and upgrading to it is pretty easy. Upgrading to v0.126.0 will make the next upgrading to v0.127.0 a bit easier as well

For Reviewers

open-telemetry/opentelemetry-collector-contrib#39767 - change in contrib related to the datadog exporter metrics config instrumentation_scope_metadata_as_tags changed default value to true

PR Checklist

  • Tests updated
  • Config converters updated

@mar4uk mar4uk marked this pull request as ready for review June 5, 2025 13:43
@mar4uk mar4uk requested review from clayton-cornell and a team as code owners June 5, 2025 13:43
@mar4uk mar4uk force-pushed the update-otel-deps branch from 62c262a to 1650186 Compare June 5, 2025 14:34
@mar4uk mar4uk changed the title update otel deps from v0.125.0 to v0.126.0 [WIP] update otel deps from v0.125.0 to v0.126.0 Jun 5, 2025
@clayton-cornell
Copy link
Contributor

If we update the OTel version, the main _index.md and _index.md.tfiles in the docs needs a variable update as well (update the*.tfile and runmake generate-versioned-files`).

There's a PR in-progress that updates these files to v0.125.1 #3790 I'm guessing that since this is marked as WIP, the other PR will probably merge first and there won't be any collisions.

@@ -81,7 +83,13 @@ You can use the following blocks with `otelcol.auth.oauth2`:
The `tls` block configures TLS settings used for connecting to the token client.
If the `tls` block isn't provided, TLS won't be used for communication.

{{< docs/shared lookup="reference/components/otelcol-tls-client-block.md" source="alloy" version="<ALLOY_VERSION>" >}}
\{\{< docs/shared lookup="reference/components/otelcol-tls-client-block.md" source="alloy" version="<ALLOY_VERSION>" >\}\}
Copy link
Contributor

@clayton-cornell clayton-cornell Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something broke here? We don't need to escape the curly brackets... Same throughout the topics here... copy pasted the error?

| Block | Description | Required |
|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|
| [`histogram`][histogram] | Configures the histogram derived from spans durations. | yes |
| `histogram` > [`dimension`][dimension] | Span event attributes to add as dimensions to the duration metric, _on top of_ the default ones and the ones configured in the top-level `dimension` block | no |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @clayton-cornell - as this block is nested, I wanted it by its parent, however the parent is required and it is not. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. There are cases like that scattered throughout the component docs. I clustered them exactly like this. This makes sense.

@dehaansa
Copy link
Contributor

The only relevant thing I didn't pull in from the otel changelog was the datadogreceiver's 128bit traceID support. This seems like a great thing to bring in, but I was just triaging an issue with it earlier this week and want to be sure it's ready for production use before we enable it by default, as we don't have a pattern right now for supporting otelcol feature flags being configured by the user.

- `datadogreceiver`: Support 128 bits TraceIDs coming from Datadog (#36926)
  This fix is released behind a featuregate so as to not be a breaking change for users. To enable it, enable 
  `receiver.datadogreceiver.Enable128BitTraceID`. The feature uses an LRU cache that will keep the last 100 trace ids by
  default. This can be configured via `receivers.datadog.trace_id_cache_size`.

@dehaansa dehaansa changed the title [WIP] update otel deps from v0.125.0 to v0.126.0 Update otel deps from v0.125.0 to v0.126.0 Jun 10, 2025
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, so giving it LGTM % comments

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise good to go.

| Block | Description | Required |
|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|
| [`histogram`][histogram] | Configures the histogram derived from spans durations. | yes |
| `histogram` > [`dimension`][dimension] | Span event attributes to add as dimensions to the duration metric, _on top of_ the default ones and the ones configured in the top-level `dimension` block | no |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. There are cases like that scattered throughout the component docs. I clustered them exactly like this. This makes sense.

Comment on lines 119 to 120
| `histogram` > [`explicit`][explicit] | Configuration for a histogram with explicit buckets. | no |
| `histogram` > [`exponential`][exponential] | Configuration for a histogram with exponential buckets. | no |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move these two up with the parent histogram block as well.

@dehaansa dehaansa enabled auto-merge (squash) June 10, 2025 17:09
@dehaansa dehaansa merged commit 529eed0 into grafana:main Jun 10, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants