Skip to content

Add push and publish Github Action files #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

beejeebus
Copy link
Contributor

@beejeebus beejeebus commented Jun 9, 2025

These files mostly copy-pasta from the instructions in Plugins Platform
(excellent) documentation for migrating from Drone to GHA.

Changes to `pkg/plugin/driver_test.go` are to keep the linter happy.

We are already using GHA for testing on PRs, so this PR only brings in
the publish bits for GHA.

@beejeebus beejeebus requested a review from a team as a code owner June 9, 2025 14:24
@beejeebus beejeebus requested a review from aangelisc June 9, 2025 14:24
@bossinc
Copy link
Collaborator

bossinc commented Jun 9, 2025

We are running tests using GHA now. We should remove those in favor of this GHA

@bossinc bossinc self-requested a review June 9, 2025 14:30
@beejeebus beejeebus force-pushed the justinrandell/migrate-to-GHA-from-Drone branch from 64f5407 to 8dd98eb Compare June 9, 2025 14:42
@beejeebus
Copy link
Contributor Author

We are running tests using GHA now. We should remove those in favor of this GHA

I think we should remove the push.yml from this PR. we only need the publish.yml bits to be able to turn off Drone. I think.

@beejeebus beejeebus force-pushed the justinrandell/migrate-to-GHA-from-Drone branch from 8dd98eb to 7d9f4fa Compare June 9, 2025 15:06
bossinc
bossinc previously approved these changes Jun 9, 2025
These files mostly copy-pasta from the instructions in Plugins Platform
(excellent) documentation for migrating from Drone to GHA.

Changes to `pkg/plugin/driver_test.go` are to keep the linter happy.

We are already using GHA for testing on PRs, so this PR only brings in
the publish bits for GHA.
@beejeebus beejeebus force-pushed the justinrandell/migrate-to-GHA-from-Drone branch from 7d9f4fa to ecb7b82 Compare June 10, 2025 13:14
@beejeebus beejeebus merged commit 4a426f2 into main Jun 10, 2025
18 checks passed
@beejeebus beejeebus deleted the justinrandell/migrate-to-GHA-from-Drone branch June 10, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants