-
Notifications
You must be signed in to change notification settings - Fork 72
Update grpc, maintain health check interface; requries go update #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why tests fail?
No I'm a little confused why the tests are failing. They timeout locally, but I don't PR this repo often enough to know what's normal. I'll dig around some today. |
Note that if I run the test individually which are failing in this PR, they pass locally.
|
It's not flakiness is it @zalegrala? |
Hmm, possibly yes. I do get a failure if I run with
|
I guess failing tests need some un-flaking then :) |
At least one of the failures looks like |
I've raised #691. Let's see what happens in CI over there. |
1076657
to
7299073
Compare
What this PR does:
Here we update the
grpc
version, which requires two changes. First a Go update to1.23
and second an interface update to includeList()
method. The implementation simply wraps theCheck
method.I invented a key here, which seemed to suit the change, but perhaps "default" could be as well. I also notice that we have an individual check for all services wrapped in a closure, but perhaps a future change might modify the
List
method to include the status of each of the manager's services.Which issue(s) this PR fixes:
Dependabot PRs updating dependencies which include newer grpc. For an example: grafana/tempo#5097
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]