Skip to content

Move GrafanaCfg to dedicated package #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

wbrowne
Copy link
Contributor

@wbrowne wbrowne commented Mar 26, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Compatibility

➜  gorelease -base=v0.274.0 -version=v0.275.0
# github.com/grafana/grafana-plugin-sdk-go/backend
## incompatible changes
ConvertFromProtobuf.GrafanaConfig: changed from func(map[string]string) *GrafanaCfg to func(map[string]string) *github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg
ConvertToProtobuf.GrafanaConfig: changed from func(*GrafanaCfg) map[string]string to func(*github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg) map[string]string
FeatureToggles: changed from FeatureToggles to github.com/grafana/grafana-plugin-sdk-go/config.FeatureToggles
GrafanaCfg: changed from GrafanaCfg to github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg
GrafanaConfigFromContext: changed from func(context.Context) *GrafanaCfg to func(context.Context) *github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg
NewGrafanaCfg: changed from func(map[string]string) *GrafanaCfg to func(map[string]string) *github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg
PluginContext.GrafanaConfig: changed from *GrafanaCfg to *github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg
Proxy: removed
SQLConfig: removed
WithGrafanaConfig: changed from func(context.Context, *GrafanaCfg) context.Context to func(context.Context, *github.com/grafana/grafana-plugin-sdk-go/config.GrafanaCfg) context.Context

# github.com/grafana/grafana-plugin-sdk-go/config
## compatible changes
package added

# github.com/grafana/grafana-plugin-sdk-go/live
## compatible changes
ScopeWatch: added

# summary
v0.275.0 is a valid semantic version for this release.

@wbrowne wbrowne self-assigned this Mar 26, 2025
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue or PR without activity label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue or PR without activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant