Fix: Issues with using a websocket k6 typescript enum type #4623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow error handling, a parameter is added to eventLoop to define whether it should wait for callback functions Signed-off-by: Fernando-hub527 <[email protected]>
Signed-off-by: Fernando-hub527 <[email protected]>
Signed-off-by: Fernando-hub527 <[email protected]>
Signed-off-by: Fernando-hub527 <[email protected]>
Signed-off-by: Fernando-hub527 <[email protected]>
Fernando-hub527
requested review from
joanlopez and
oleiade
and removed request for
a team
|
|
mimani68
approved these changes
Mar 16, 2025
Contributor
|
Hey @Fernando-hub527 👋🏻 Thanks for putting the time and effort in doing this. I've commented on the original issue, and will wait for an answer there before considering reviewing and merging this 🙇🏻 |
Signed-off-by: Fernando-hub527 <[email protected]>
Contributor
|
Hey @Fernando-hub527 👋🏻 Apologies for the delay, but after clarifications in the issue, it seems this PR is not needed, as it was found out that EventName was really a concept there to support the DefinitelyTyped type definitions, and shouldn't be introduced in the Go code itself. As far as we can tell anyway. I'll close this, but feel free to reopen in the future if relevant, and thanks a lot again for your contribution nonetheless 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure that all enums that can be used in the WebSocket module are correctly mapped.
Why?
According to issue #4540 , when using 'EventName.Open' in the script, an error was returned indicating that 'open' was undefined.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
#4540