-
Notifications
You must be signed in to change notification settings - Fork 21
feat(table): core table unification #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4f7262c
to
4e8bd80
Compare
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded
Removed
Bigger No assets were bigger Smaller
View module informationAdded
Removed No modules were removed Bigger
Smaller
|
@L2D2Grafana the code looks good at a glance, I'll dig in more later this week, but I'm noticing that there are some conflicts with the sidebar from the new logs panel: Issues on main/ don't fix in this PR: Also if you put a numeric column first the buttons get all messed up |
0848d57
to
3fb1bce
Compare
f97ce05
to
0024530
Compare
0024530
to
44a22aa
Compare
zIndex: 10, | ||
}), | ||
rzHandle: css({ | ||
[theme.transitions.handleMotion('no-preference', 'reduce')]: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for background transitions we don't need to respect the reduced motion unless something is actively moving, color/opacity transitions should be fine?
background: theme.colors.secondary.main, | ||
borderRadius: theme.shape.radius.pill, | ||
cursor: 'grab', | ||
height: '50% !important', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's an !important I'd like to see a comment explaining why there is no other solution available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1286
Screen.Recording.2025-06-20.at.12.16.41.PM.mov