Skip to content

refactor(ng-table): try ng-table #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

L2D2Grafana
Copy link
Collaborator

Spike to try out the new ng-table component. Some issues I'm looking into if anyone has insight, lmk 💡

  • No custom headerComponent supported
            headerComponent: (props: CustomHeaderRendererProps) => ()
  • Turned off inspect true, but it's still visible it on right click and seems to take up some space in the dom
    Screenshot 2025-06-25 at 9 46 53 AM

  • cellContextMenu is cut off and no about of position absolute or zIndex seems to fix it
    Screenshot 2025-06-25 at 9 47 47 AM
    menu: css({
    display: 'flex',
    justifyContent: 'flex-start',
    left: 0,
    minWidth: '60px',
    paddingRight: '5px',
    position: 'absolute',
    top: 20,
    zIndex: 1000,
    }),

  • Without lokiLogsDataplane the log line looks great
    time-line-are-good
    Body shifts the whole table and I'm not quite sure yet
    Screenshot 2025-06-25 at 6 28 59 PM

Copy link
Contributor

Bundle Size Changes

Hello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes.

Whenever this PR is updated, this comment will update to reflect the latest changes.

EntryPoint Size % Diff
module 80.23 KB (-19 Bytes) -0.02%
Files Total bundle size % Diff
29 9.15 MB (-5.46 KB) -0.06%
View detailed bundle information

Added

Name Size % Diff
83.js?_cache=60f5b81f150af6e06608 657.13 KB (+657.13 KB) -
328.js?_cache=dfab5e18b2b816f6317a 420.54 KB (+420.54 KB) -
470.js?_cache=29dd26bce42815d67980 161.22 KB (+161.22 KB) -
944.js?_cache=c9770b9500ce5eb4bbe7 11.11 KB (+11.11 KB) -
854.js?_cache=9da793b3efc18875808d 10.41 KB (+10.41 KB) -
826.js?_cache=bbd4b8fa9b484ef3da47 4.26 KB (+4.26 KB) -
677.js?_cache=459e2f48fafbd65cef80 2.39 KB (+2.39 KB) -
546.js?_cache=8e0beb2f22d2cbf6b122 1.24 KB (+1.24 KB) -
919.js?_cache=c4d71551d985ac2d78ea 783 Bytes (+783 Bytes) -
82.js?_cache=dfe23578db084e080492 510 Bytes (+510 Bytes) -

Removed

Name Size % Diff
83.js?_cache=7d0001eb5cec9ec20659 0 Bytes (-658.95 KB) -100.00%
328.js?_cache=6ae139b647e698f52b12 0 Bytes (-424.13 KB) -100.00%
470.js?_cache=3204c8fc47e32152da72 0 Bytes (-161.06 KB) -100.00%
944.js?_cache=f71d4a80dffcd450b1ad 0 Bytes (-11.12 KB) -100.00%
854.js?_cache=dfc3af049daeccb14055 0 Bytes (-10.42 KB) -100.00%
826.js?_cache=6564b74ba9a88748417c 0 Bytes (-4.41 KB) -100.00%
677.js?_cache=07af0fd5f595e89a547a 0 Bytes (-2.4 KB) -100.00%
546.js?_cache=6f5ddc8aa7794d51d98a 0 Bytes (-1.24 KB) -100.00%
919.js?_cache=7be6ddd4150bd05cd8b5 0 Bytes (-785 Bytes) -100.00%
82.js?_cache=8aeb0e8d14bf6a95b54f 0 Bytes (-512 Bytes) -100.00%

Bigger

No assets were bigger

Smaller

Name Size % Diff
module.js 80.23 KB (-19 Bytes) -0.02%
View module information

Added

Name Size % Diff
clsx 397 Bytes (+397 Bytes) -

Removed

No modules were removed

Bigger

Name Size % Diff
i18next-browser-languagedetector 13.99 KB (+1.74 KB) +14.18%
semver 63.13 KB (+704 Bytes) +1.10%
@grafana/e2e-selectors 66.64 KB (+491 Bytes) +0.72%
@floating-ui/core 35.27 KB (+430 Bytes) +1.20%
@floating-ui/dom 25.78 KB (+173 Bytes) +0.66%
react-scroll-sync 52.01 KB (+170 Bytes) +0.32%
./Components/IndexScene/IndexScene.tsx 31.61 KB (+96 Bytes) +0.30%
./module.tsx 2.96 KB (+44 Bytes) +1.47%
@floating-ui/react-dom 10.33 KB (+41 Bytes) +0.39%
./Components/Table/LogLineCellComponent.tsx 6.91 KB (+24 Bytes) +0.34%
react-i18next 25.89 KB (+15 Bytes) +0.06%

Smaller

Name Size % Diff
react-draggable 51.56 KB (-2.01 KB) -3.76%
./Components/ServiceScene/Breakdowns/FieldValuesBreakdownScene.tsx 20.47 KB (-776 Bytes) -3.57%
./services/TagKeysProviders.ts 8.01 KB (-715 Bytes) -8.02%
./Components/Table/Table.tsx 18.59 KB (-542 Bytes) -2.77%
./services/TagValuesProviders.ts 9.99 KB (-419 Bytes) -3.93%
./Components/ServiceScene/Breakdowns/LabelValuesBreakdownScene.tsx 22.91 KB (-388 Bytes) -1.63%
./Components/Panels/PanelMenu.tsx 18.04 KB (-356 Bytes) -1.89%
./services/keyboardShortcuts.ts 7.53 KB (-322 Bytes) -4.01%
./Components/AppConfig/AppConfig.tsx 8.5 KB (-295 Bytes) -3.28%
./services/datasource.ts 24.62 KB (-259 Bytes) -1.02%
./Components/IndexScene/ShareButtonScene.tsx 8.83 KB (-256 Bytes) -2.75%
./services/scenes.ts 3.2 KB (-165 Bytes) -4.80%
./Components/ServiceScene/Breakdowns/Patterns/PatternNameLabel.tsx 7.65 KB (-155 Bytes) -1.94%
./Components/ServiceScene/Breakdowns/LineFilterInput.tsx 5.56 KB (-121 Bytes) -2.08%
@tanstack/virtual-core 27.87 KB (-97 Bytes) -0.34%
./services/panel.ts 12.83 KB (-42 Bytes) -0.32%
./Components/ServiceScene/Breakdowns/Patterns/PatternsFrameScene.tsx 13.14 KB (-28 Bytes) -0.21%

@L2D2Grafana
Copy link
Collaborator Author

Looks like the tests are breaking with the newer version of grafana/ui
Cannot find module 'uwrap' from 'node_modules/@grafana/ui/dist/cjs/unstable-Dqojcxnv.js'

@L2D2Grafana L2D2Grafana closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant