Skip to content

feat(): fields cardinality breakdowns - poc #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gtk-grafana
Copy link
Contributor

PoC of #1373

@matyax
Copy link
Contributor

matyax commented Jul 3, 2025

I like this a lot! Also how it's integrated with the tab.

imagen

What I do see is that the sampled cardinality is both innacurate and potentialy confusing. What about just showing it without any metric?

It would also be interesting to see how the instant queries look like for the values breakdown. Great work!

@matyax
Copy link
Contributor

matyax commented Jul 3, 2025

@trevorwhitney Do you think having an alternative view that users an instant query for metrics instead of a full range query would improve responsiveness/decrease work load? For the fields breakdown, btw.

@gtk-grafana
Copy link
Contributor Author

gtk-grafana commented Jul 3, 2025

What I do see is that the sampled cardinality is both innacurate and potentialy confusing. What about just showing it without any metric?

It's not inaccurate, just a sample, the tooltip should call this out, and why I wanted to include "sampled" in the toggle, but yeah it could cause confusion and we could certainly just show the names, I wanted to go big for PoC to help spark ideation, but we can dial it back for MVP if we decide to move forward on something like this.

It would also be interesting to see how the instant queries look like for the values breakdown. Great work!

We typically show instant query results in a table, which is probably the best, but not as sexy as a barchart (but barchart would be unreadable for fields with cardinality greater then 10-20). I wonder if we could get a stat and a table working, either as a panel menu toggle or just by shoving them both in the panel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants