distributor: reintroduce cortex_distributor_sample_delay_seconds as a native histogram
#11573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tacole02
approved these changes
May 28, 2025
@krajorama @dimitarvdimitrov do you have opinion about adding this metric back (as a native histogram)? In #7516, krajo mentioned "it wasn't useful in a multi tenant environment", but I don't have historical context. |
Co-authored-by: Taylor C <[email protected]>
zenador
changed the title
cortex_distributor_sample_delay_seconds as a native histogram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Distributor used to expose
cortex_distributor_sample_delay_secondsclassic histogram, which was removed in #8698. We are using it for computing SLI for ingest delay.This PR readds it as a per-user native histogram.
Which issue(s) this PR fixes or relates to
#7516 #8698
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.