block-builder: remove standalone mode #11643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
seizethedave
approved these changes
Jun 6, 2025
| @@ -221,13 +189,12 @@ func (b *BlockBuilder) runningPullMode(svcCtx context.Context) error { | |||
| } | |||
|
|
|||
| // Once we've gotten a job, we attempt to complete it even if the context is cancelled. | |||
|
|
|||
| if _, err := b.consumeJob(context.Background(), key, spec); err != nil { | |||
| if _, err := b.consumeJob(context.WithoutCancel(ctx), key, spec); err != nil { | |||
| @@ -37,8 +28,9 @@ func newBlockBuilderMetrics(reg prometheus.Registerer) blockBuilderMetrics { | |||
| }, []string{"success"}) | |||
|
|
|||
| m.processPartitionDuration = promauto.With(reg).NewHistogramVec(prometheus.HistogramOpts{ | |||
| Name: "cortex_blockbuilder_process_partition_duration_seconds", | |||
| Help: "Time spent processing one partition.", | |||
| Name: "cortex_blockbuilder_process_partition_duration_seconds", | |||
There was a problem hiding this comment.
I think this one is now redundant with the similar consume_job metric. It's in some dashboards, though.
There was a problem hiding this comment.
Good point, I will clean up the dashboards after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Now, as we have block-builder-scheduler, we can remove the standalone mode, and continue iterating on top of its architecture.
This PR mechanically removes everything related the standalone mode. My idea is that after this one gets merged, we can go ahead and start looking at if there are any test scenarios missing, and gradually add those.