ruler: Fix QueryOffset being ignored when recording xor alerting rule evaluation is disabled #11647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
approved these changes
Jun 6, 2025
CHANGELOG.md
Outdated
| @@ -79,6 +79,7 @@ | |||
| * [BUGFIX] Querier and query-frontend: Fix issue where aggregation functions like `topk` and `quantile` could return incorrect results if the scalar parameter is not a constant and Prometheus' query engine is in use. #11548 | |||
| * [BUGFIX] Querier and query-frontend: Fix issue where range vector selectors could incorrectly ignore samples at the beginning of the range. #11548 | |||
| * [BUGFIX] Querier: Fix rare panic if a query is canceled while a request to ingesters or store-gateways has just begun. #11613 | |||
| * [BUGFIX] Ruler: Fix QueryOffset and AlignEvaluationTimeOnInterval being ignored when recording xor alerting rule evaluation is disabled. #11647 | |||
There was a problem hiding this comment.
recording xor alerting rule evaluation
What does the "xor" refer to here?
There was a problem hiding this comment.
"Exclusive or," the bug only happens when you have recording disabled and alerting enabled, or vice versa, it does not happen when both are disabled. I'll improve the wording a bit before merging it
dimitarvdimitrov
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When evaluation of one rule type is disabled but the other is enabled, the sync logic makes a filtered copy of each rule group. The copy logic ignores newly added fields
QueryOffsetandAlignEvaluationTimeOnInterval. We then sync these groups with the fields blapped.This PR changes the copy + tests to consider all fields as of today, and also be tolerant of newly added fields so it doesn't break again in the future.
Which issue(s) this PR fixes or relates to
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.