MQE: include trace ID in panic message if memory consumption estimate becomes negative #11713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates various test files to propagate a proper context into the memory consumption tracker and removes duplicate context initializations. The key changes include replacing direct calls to limiter.NewMemoryConsumptionTracker(0, nil, "") with calls that pass context (typically context.Background()), and removing redundant context instantiations within tests.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/streamingpromql/operators/selectors/instant_vector_selector_test.go | Passes context to memory tracker and removes duplicate ctx initialization. |
| pkg/streamingpromql/operators/operator_buffer_test.go | Updates memory tracker construction and removes redundant context definitions. |
| pkg/streamingpromql/operators/functions/*_test.go | Consistently passes a valid context to the memory tracker in various function tests. |
| pkg/streamingpromql/operators/binops/*_test.go | Updates binary operation tests to use context in memory tracker instantiation. |
| pkg/streamingpromql/operators/aggregations/*_test.go | Adapts aggregation test files to pass context and improve consistency. |
| pkg/querier/*_test.go and pkg/ingester/client/streaming_test.go | Pass context into the memory tracker, ensuring consistent propagation in streaming tests. |
colega
reviewed
Jun 12, 2025
56quarters
approved these changes
Jun 12, 2025
Contributor
56quarters
left a comment
56quarters
left a comment
There was a problem hiding this comment.
LGTM modulo Oleg's suggestion
charleskorn
added
the
changelog-not-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the trace ID (if any) to the panic message used if the estimated memory consumption of a query becomes negative.
Which issue(s) this PR fixes or relates to
#11615, #11654
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.