write path: handle created timestamp #11977
Open
+1,160
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
force-pushed
the
krajo/created-timestamp
branch
4 times, most recently
from
24c0591 to
b9e1a00
Compare
krajorama
changed the title
krajorama
force-pushed
the
krajo/created-timestamp
branch
from
b9e1a00 to
1efc74a
Compare
krajorama
force-pushed
the
krajo/created-timestamp
branch
4 times, most recently
from
36c90aa to
7774cee
Compare
krajorama
force-pushed
the
krajo/created-timestamp
branch
2 times, most recently
from
88805c5 to
44740eb
Compare
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
krajorama
force-pushed
the
krajo/created-timestamp
branch
from
44740eb to
c7ebe12
Compare
tacole02
approved these changes
Jul 7, 2025
| @@ -31,7 +31,8 @@ | |||
| * `memberlist.acquire-writer-timeout`: `1s` | |||
| These defaults perform better but may cause long-running packets to be dropped in high-latency networks. | |||
| * [CHANGE] Query-frontend: Apply query pruning and check for disabled experimental functions earlier in query processing. #11939 | |||
| * [FEATURE] Distributor: Experimental support for Prometheus Remote-Write 2.0 protocol. Limitations: Created timestamp is ignored, per series metadata is merged on metric family level automatically, ingestion might fail if client sends ProtoBuf fields out of order. The label `version` is added to the metric `cortex_distributor_requests_in_total` with a value of either `1.0` or `2.0` depending on the detected Remote-Write protocol. #11100 #11101 #11192 #11143 | |||
| * [FEATURE] Distributor: Experimental support for Prometheus Remote-Write 2.0 protocol. Limitations: if samples in a write request are not ordered by time, the created timestamp might be dropped, per series metadata is merged on metric family level automatically, ingestion might fail if client sends ProtoBuf fields out of order. The label `version` is added to the metric `cortex_distributor_requests_in_total` with a value of either `1.0` or `2.0` depending on the detected Remote-Write protocol. #11100 #11101 #11192 #11143 #11977 | |||
There was a problem hiding this comment.
Suggested change
| * [FEATURE] Distributor: Experimental support for Prometheus Remote-Write 2.0 protocol. Limitations: if samples in a write request are not ordered by time, the created timestamp might be dropped, per series metadata is merged on metric family level automatically, ingestion might fail if client sends ProtoBuf fields out of order. The label `version` is added to the metric `cortex_distributor_requests_in_total` with a value of either `1.0` or `2.0` depending on the detected Remote-Write protocol. #11100 #11101 #11192 #11143 #11977 | |
| * [FEATURE] Distributor: Experimental support for Prometheus Remote-Write 2.0 protocol. This feature includes some limitations. If samples in a write request aren't ordered by time, the created timestamp might be dropped. Additionally, per-series metadata is automatically merged on the metric family level, and ingestion might fail if the client sends ProtoBuf fields out-of-order. The label `version` is added to the metric `cortex_distributor_requests_in_total` with a value of either `1.0` or `2.0`, depending on the detected remote-write protocol. #11100 #11101 #11192 #11143 #11977 |
There was a problem hiding this comment.
I tried to break this up a bit for clarity. Let me know if the meaning is preserved.
There was a problem hiding this comment.
Also, I changed the second occurrence of remote-write to lower-case, since we aren't reference a specific remote-write protocol in this case.
| @@ -31,7 +31,8 @@ | |||
| * `memberlist.acquire-writer-timeout`: `1s` | |||
| These defaults perform better but may cause long-running packets to be dropped in high-latency networks. | |||
| * [CHANGE] Query-frontend: Apply query pruning and check for disabled experimental functions earlier in query processing. #11939 | |||
| * [FEATURE] Distributor: Experimental support for Prometheus Remote-Write 2.0 protocol. Limitations: Created timestamp is ignored, per series metadata is merged on metric family level automatically, ingestion might fail if client sends ProtoBuf fields out of order. The label `version` is added to the metric `cortex_distributor_requests_in_total` with a value of either `1.0` or `2.0` depending on the detected Remote-Write protocol. #11100 #11101 #11192 #11143 | |||
| * [FEATURE] Distributor: Experimental support for Prometheus Remote-Write 2.0 protocol. Limitations: if samples in a write request are not ordered by time, the created timestamp might be dropped, per series metadata is merged on metric family level automatically, ingestion might fail if client sends ProtoBuf fields out of order. The label `version` is added to the metric `cortex_distributor_requests_in_total` with a value of either `1.0` or `2.0` depending on the detected Remote-Write protocol. #11100 #11101 #11192 #11143 #11977 | |||
| * [FEATURE] Ingester/Block-builder: handle the Created timestamp field of write requests. #11977 | |||
There was a problem hiding this comment.
Suggested change
| * [FEATURE] Ingester/Block-builder: handle the Created timestamp field of write requests. #11977 | |
| * [FEATURE] Ingester/Block-builder: Handle the timestamp field for write requests. #11977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Modify the ingester and block builder to accept and pass the Created timestamp field from incoming write requests to TSDB.
Note1: if samples aren't ordered by time in a remote write requests, then the result is undefined.
Note2: as with regular samples, Mimir will have non-deterministic behavior if there's a sample and a created timestamp with the same timestamp ingested on two different ingesters for whatever reason. During query and block building the resolution of such conflicting samples has always been non-deterministic, as there is no way to know at that point which sample is the correct one.
Which issue(s) this PR fixes or relates to
Fixes #11976
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.