Alertmanager: Check error code fron pre-notify hooks, and ignore 204. #11985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We we're correctly checking the error code, which was seemingly fine unless the hook returned valid JSON, in which case this was parsed as a valid payload. Additionally, allow the hook to return 204 (No Content) to indicate it did not perform any processing, and do not log errors in this case.
fayzal-g
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't correctly checking the error code, which was seemingly fine unless the
hook returned valid JSON, in which case this was parsed as a valid payload.
Additionally, allow the hook to return 204 (No Content) to indicate it did not
perform any processing, and do not log errors in this case.