Block-builder-scheduler: avoid committing offsets for partitions that have had no consumption #12130
+82
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
There was a bug introduced in #11867 where if a block-builder-scheduler encounters a partition in this state:
then:
0
in its statewhich leads to:
0
for the partition in thecortex_blockbuilder_scheduler_partition_committed_offset
gauge.(This can happen if the partition was hasn't been written to since before the scheduler or its consumer group existed in that environment.)
To fix this, I am introducing a special state of
offsetEmpty
(-1
) to the offsets that are handled specially.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
. If changelog entry is not needed, please add thechangelog-not-needed
label to the PR.about-versioning.md
updated with experimental features.