Skip to content

feat: [StepSecurity] Apply security best practices #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @iainlane. Please merge the Pull Request to incorporate the requested changes. Please tag @iainlane on your message if you have any questions related to the PR.

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Harden Runner

Harden-Runner is an open-source security agent for the GitHub-hosted runner to prevent software supply chain attacks. It prevents exfiltration of credentials, detects tampering of source code during build, and enables running jobs without sudo access. See how popular open-source projects use Harden-Runner here.

Harden runner usage

You can find link to view insights and policy recommendation in the build log

Please refer to documentation to find more details.

Secure Dockerfiles

Pin image tags to digests in Dockerfiles. With the Docker v2 API release, it became possible to use digests in place of tags when pulling images or to use them in FROM lines in Dockerfiles.

Add Dependency Review Workflow

The Dependency Review Workflow enforces dependency reviews on your pull requests. The action scans for vulnerable versions of dependencies introduced by package version changes in pull requests, and warns you about the associated security vulnerabilities. This gives you better visibility of what's changing in a pull request, and helps prevent vulnerabilities being added to your repository.

Add OpenSSF Scorecard Workflow

OpenSSF Scorecard is an automated tool that assesses a number of important heuristics ("checks") associated with software security and assigns each check a score of 0-10. You can use these scores to understand specific areas to improve in order to strengthen the security posture of your project.

Scorecard workflow also allows maintainers to display a Scorecard badge on their repository to show off their hard work.

Maintain Code Quality with Pre-Commit

Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks. Hooks can be any scripts, code, or binaries that run at any stage of the git workflow. Pre-commit hooks are useful for enforcing code quality, code formatting, and detecting security vulnerabilities.

Feedback

For bug reports, feature requests, and general feedback; please email [email protected]. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot [email protected]

@step-security-bot step-security-bot requested review from a team as code owners April 29, 2025 12:04
@iainlane
Copy link
Member

We have some CI workflows that don't work for forks. I'll fix those!

@iainlane iainlane force-pushed the chore/GHA-291204-stepsecurity-remediation branch from 61b18f8 to 7010f52 Compare April 30, 2025 10:20
@iainlane iainlane changed the title [StepSecurity] Apply security best practices feat: [StepSecurity] Apply security best practices Apr 30, 2025
@iainlane iainlane force-pushed the chore/GHA-291204-stepsecurity-remediation branch from f9d638f to 08ec4f8 Compare April 30, 2025 10:39
@iainlane
Copy link
Member

I've pushed changes here so I can't really review

step-security-bot and others added 4 commits April 30, 2025 14:26
Mainly adding `persist-credentials: false` in one place, and triggering
the new dependency review action from the merge queue.
The one created by Step Security wasn't quite in line with our
configuration.
This is only available to us in public repositories right now, so make
this conditional for our reusable workflows.
@iainlane iainlane force-pushed the chore/GHA-291204-stepsecurity-remediation branch from 08ec4f8 to f7d8628 Compare April 30, 2025 13:26
@iainlane iainlane added this pull request to the merge queue May 6, 2025
Merged via the queue into grafana:main with commit 0363d37 May 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants