Add trace logs from driver #29
Merged
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c0e1d7.
schmikei
approved these changes
Jun 16, 2025
dehaansa
reviewed
Jun 24, 2025
collector/config.go
Outdated
| @@ -119,6 +119,7 @@ func (c Config) snowflakeConnectionString() (string, error) { | |||
| Role: c.Role, | |||
| Warehouse: c.Warehouse, | |||
| Database: "SNOWFLAKE", | |||
| Tracing: "trace", | |||
There was a problem hiding this comment.
This should be configurable, can we have this be confgured via a new configuration parameter to ensure the logs aren't too noisy when not debugging an issue?
There was a problem hiding this comment.
+1, having it be configurable would be ideal
There was a problem hiding this comment.
Yes, I'll update it this week.
There was a problem hiding this comment.
@dehaansa @Dasomeone Updated. I tested running the exporter with and without this flag set, it worked as expected.
Dasomeone
approved these changes
Jun 26, 2025
dehaansa
approved these changes
Jun 26, 2025
|
@Dasomeone I cannot merge this, can you? |
|
Of course @kuiperda , apologies forgot you can't on this repo :) |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add trace logging from the driver. Also add missing 'finished collection' message for deleted tables.