Skip to content

Conversation

Copy link

Copilot AI commented Nov 28, 2025

Two issues from code review of PR #343's function naming refactor.

Changes

  • Fix object_type typo in JamfSoftwareRestrictionUploaderBase.py:200
    "restricted_softwareq""restricted_software"
    API lookups would fail with the extra 'q'

  • Remove unused assignment in JamfPkgMetadataUploaderBase.py:318

    # Before
    object_id = self.update_pkg_metadata_api(...)
    
    # After  
    self.update_pkg_metadata_api(...)

    Return value was assigned but never used

Original prompt

Two changes were suggested during code review for pull request #343:

  1. Fix a typo in the object_type parameter in the file JamfUploaderProcessors/JamfUploaderLib/JamfSoftwareRestrictionUploaderBase.py, where "restricted_softwareq" should be corrected to "restricted_software".
  2. Remove the unused variable object_id in the file JamfUploaderProcessors/JamfUploaderLib/JamfPkgMetadataUploaderBase.py. Adjust the function call to directly use the method without assigning it to the unused variable.

This pull request was created as a result of the following prompt from Copilot chat.

Two changes were suggested during code review for pull request #343:

  1. Fix a typo in the object_type parameter in the file JamfUploaderProcessors/JamfUploaderLib/JamfSoftwareRestrictionUploaderBase.py, where "restricted_softwareq" should be corrected to "restricted_software".
  2. Remove the unused variable object_id in the file JamfUploaderProcessors/JamfUploaderLib/JamfPkgMetadataUploaderBase.py. Adjust the function call to directly use the method without assigning it to the unused variable.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 28, 2025
grahampugh and others added 2 commits November 28, 2025 18:58
- Fix typo in object_type parameter: 'restricted_softwareq' -> 'restricted_software'
- Remove unused variable object_id in JamfPkgMetadataUploaderBase.py

Co-authored-by: grahampugh <[email protected]>
Copilot AI changed the title [WIP] Fix typo in object_type parameter and remove unused variable Fix typo and remove unused variable in function naming refactor Nov 28, 2025
Copilot AI requested a review from grahampugh November 28, 2025 19:03
Copilot finished work on behalf of grahampugh November 28, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants