build: add dependency on the GSP Plugin #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the `GroovyPagesTemplateEngine` and `GroovyPagesUriService` beans registered as they are injected in `MailConfiguration`.
|
Fixes #73 |
sbglasius
approved these changes
Apr 30, 2025
| @@ -39,6 +39,11 @@ dependencies { | |||
| implementation libs.spring.beans | |||
| implementation libs.springboot.autoconfigure | |||
|
|
|||
| runtimeOnly libs.grails.plugin.gsp, { | |||
| // The GSP Plugin registers the GroovyPagesTemplateEngine and | |||
There was a problem hiding this comment.
Why the closure instead of just a comment above?
There was a problem hiding this comment.
It will keep the comment connected to the dependency over time. I have seen many times where dependency comments drift when stuff is added/removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the
GroovyPagesTemplateEngineandGroovyPagesUriServicebeans registered as they are injected inMailConfiguration.