-
Notifications
You must be signed in to change notification settings - Fork 28
Refactor JointRule process to accomodate PlateJoint #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
obucklin
wants to merge
99
commits into
main
Choose a base branch
from
plate_joint_GH_comps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 64.05% 65.41% +1.36%
==========================================
Files 76 76
Lines 10887 10954 +67
==========================================
+ Hits 6974 7166 +192
+ Misses 3913 3788 -125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was
linked to
issues
Jul 11, 2025
Closed
This was
unlinked from
issues
Jul 11, 2025
Closed
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I wanted to make GH components for the new PlateJoints. This required a rework of the JointRules themselves.
Changes to JointRule application:
I reworked the
comply()
methods, and realized we had a lot of redundant checks in the process. I tried to rationalize the rule parsing and joint creation a bit. The new concept is a three part process:JointRule
creation. No distance, topology, or other compliance checks are done here.Joint
creation viaDirectRule.get_joint
orCategoryRule
/TopologyRule.try_get_joint
. This is where all checks are done.DirectRule.get_joint
raises aBeamJoiningError
if it fails, but the others take a pair of elements and return a Joint if possible, otherwiseNone
.Because the
Joint
is generated outside the context of a model, I implemented aJoint.from_element_list()
method. This allows us to separate instantiating theJoint
and adding it to theTimberModel
.Joints that take different input parameters e.g. the
BallNodeJointoverride this method.
Joint.create()` functions as previously. PR #491Changes to GH Components:
Model
component by extracting sections into various methods. We should look and see if these can be upstreamed to their respective modules.JointDefinition
andFeatureDefinition
.There are 2 other PRs now upon which this depends: #500 and #501. once they are merged we can look at this.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.