Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cpp and rust tests on ci #1073

Open
wants to merge 1 commit into
base: master-dev
Choose a base branch
from

Conversation

crop2000
Copy link
Contributor

@crop2000 crop2000 commented Oct 26, 2024

based on #1068
a lot of work was caused by #1075

@crop2000 crop2000 changed the title attempt to fix tests on ci add cpp and rust tests on ci Oct 26, 2024
@crop2000 crop2000 force-pushed the ci_tests branch 4 times, most recently from e5ca800 to a148222 Compare October 26, 2024 21:17

- name: Run impulse tests (C++)
run: cd tests/impulse-tests && make travis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that the target is called "travis" (tests don't run on Travis CI, no?). But of course that's somewhat independent of this PR, if it happens to be called like this already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a subset of the cpp tests that finishes in below 1h

@crop2000
Copy link
Contributor Author

@sletz what do you think about this?
To run the tests takes about 80min.

@sletz
Copy link
Member

sletz commented Oct 29, 2024

This is too long, I suggest modifying the make travis target to only keep the first line.

@crop2000
Copy link
Contributor Author

@sletz is the travis target used elsewhere? if not i would rename it to github_action and describe a meaning full subset. maybe it makes sense to have a detailed check that is not part of the default actions, but can be activated to ensure a thorough check for more complex changes.

@crop2000
Copy link
Contributor Author

@sletz down to ~20m for everything ~5min build faust, ~15min c++ and rust

setup github action to run tests
the tests needed some changed to work on github
remove prefix ir from gcc tests
remove constant.dsp  ir from gcc mapp tests
improve rust impule_test makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants