Skip to content

Conversation

@SNoiraud
Copy link
Member

@SNoiraud SNoiraud commented Mar 2, 2025

Using the calendar for old dates is very tedious.
Going back to 1625 can take some time.

I added the possibility to select directly the person's birth, the person's death, the family marriage or the event date when you change the active object.

I'll show some screenshot for that.

@SNoiraud SNoiraud added this to the v6.1 milestone Mar 2, 2025
@SNoiraud
Copy link
Member Author

SNoiraud commented Mar 2, 2025

calendar birth 1

calendar death 1

calendar death 2

calendar family 1

calendar family 2

calendar event 1

@Nick-Hall
Copy link
Member

@SNoiraud You need to upgrade your copy black to version 25.1.0 to avoid the linting errors.

@SNoiraud
Copy link
Member Author

SNoiraud commented Mar 3, 2025

Upgrading black make nothing. All my files are correct, but if I look at in the log the problem is in:

import unittest
import os
would reformat /home/runner/work/gramps/gramps/po/test/po_test.py

Oh no! 💥 💔 💥
59 files would be reformatted, 1132 files would be left unchanged.

@Nick-Hall
Copy link
Member

I also had to merge the new formatting in the gramps60 branch into master. This should be fixed now.

SNoiraud added 3 commits March 3, 2025 16:42
For the active person, if you use the "Person Calendar" gramplet,
the birth date will be shown on the calendar.

For the active family, if you use the "Family Calendar" gramplet,
the marriage date will be shown on the calendar.

For the active event, if you use the "Event Calendar" gramplet,
the event date will be shown on the calendar.

You can always us the calendar in the dashboard.
The double click will do the same things as before.
1 - Addition of person's death calendar.
2 - Sometimes the first use does not work.
3 - Separate all classes.
4 - Added a copyright
@Nick-Hall
Copy link
Member

Rebased.

@emyoulation
Copy link
Contributor

emyoulation commented Mar 29, 2025

Serge,

Is it possible to add a similar expansion in the Date Selection dialog? Or if this PR just has variants of the Calendar gramplet rather than tabs, then your experience in this PR may not be applicable. (Either way, such a feature will need a new enhancement request.) I just want your opinion about whether it is a reasonable request.

Dual tabbed Calendars ("Date" and "Second date") that poll and push dates from the associated fields would be a huge improvement. (I often find newspaper articles that refer to a birth/death "last Thursday" or funeral/wedding that will be "next Tuesday" ... where the current day of the week was not recorded.)

126e2bd68cea43d1e4902ccaee8d0deb28a4f7c1

@SNoiraud
Copy link
Member Author

SNoiraud commented Mar 30, 2025

I just want you opinion about whether it is a reasonable request.

It seems reasonable.
I have however a little problem with calendars that are not Gregorian (French revolutionary, ...)
The Gtk calendar only shows positives gregorian dates.

I can look at this and will post a snapshot example.

second problem: Glade will not exist in Gtk4. As I don't know what will be the future, I'll add these widget into the table48 grid.

Here is an example of what we could have:
date-editor 1

@QuLogic
Copy link
Contributor

QuLogic commented Mar 31, 2025

second problem: Glade will not exist in Gtk4. As I don't know what will be the future, I'll add these widget into the table48 grid.

Glade the UI designer does not exist (though you can use its replacement Cambalache), but the UI-in-XML building still exists and will work just fine.

@SNoiraud
Copy link
Member Author

I am not sure Cambalache will be the glade replacement.

@emyoulation
Copy link
Contributor

Thank you for the reception, feedback and suggestions.
added a Enhancement request for the Dual tabbed calendars:
https://gramps-project.org/bugs/view.php?id=13754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants