Skip to content

Conversation

@oliverpool
Copy link

Following #52 (which seems stale), this adds a RegisterServiceEntry function.

What's the benefit over Register?

To be able to override specific fields of the ServiceEntry (the HostName for instance, without having to provide ips).

Given there should be an extended API, code should be reused rather than duplicated.

I refactored the Register and RegisterProxy to use this new method.

Also, test coverage should be added.

I have added some basic tests, to check that the fields are properly set.

Let me know what you think!

@oliverpool oliverpool force-pushed the register_service_entry branch from ec6914c to f7c74fb Compare April 24, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant