Handle execution payload bid #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangleang
force-pushed
the
feature/validate-payload-bid
branch
2 times, most recently
from
c0de6fb to
045c02d
Compare
hangleang
force-pushed
the
epbs
branch
2 times, most recently
from
968d5ac to
2a96e60
Compare
hangleang
force-pushed
the
feature/validate-payload-bid
branch
from
045c02d to
37838ce
Compare
hangleang
force-pushed
the
feature/validate-payload-bid
branch
2 times, most recently
from
b48f2f3 to
b2d4e5e
Compare
hangleang
force-pushed
the
feature/validate-payload-bid
branch
from
b2d4e5e to
9195a6e
Compare
hangleang
force-pushed
the
feature/validate-payload-bid
branch
from
29d9529 to
3267ce3
Compare
povi
reviewed
Dec 10, 2025
| ) | ||
| } | ||
|
|
||
| fn spawn_execution_payload_bid_task_with_wait_group( |
Collaborator
There was a problem hiding this comment.
No need to have a separate spawn_execution_payload_bid_task_with_wait_group method if you don't plan to use it again somewhere else
povi
reviewed
Dec 10, 2025
|
|
||
| impl<P: Preset, E, W> Spawn<P, E, W> for ExecutionPayloadBidTask<P, W> { | ||
| fn spawn(self, critical: &mut Critical<P, E, W>) { | ||
| critical.low_priority_tasks.push_back(self.into()) |
Collaborator
There was a problem hiding this comment.
I'm not sure if it should be low or mid priority task
Collaborator
Author
There was a problem hiding this comment.
I will mark TODO there to figure out later
povi
reviewed
Dec 10, 2025
fork_choice_store/src/store.rs
Outdated
| let builder_index = bid.builder_index; | ||
|
|
||
| // > off-protocol payment is disallowed in gossip, the `bid.execution_payment` MUST be zero | ||
| if origin.is_from_gossip() { |
Collaborator
There was a problem hiding this comment.
What about bids from POST /eth/v1/beacon/execution_payload_bid? Are they allowed to have non-zero execution_payment?
Collaborator
Author
There was a problem hiding this comment.
bid submitted from the API need to pass the gossip validations, so it should also disallow
povi
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #484