Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add price per weight ratio #722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UnknownSilicon
Copy link

Adds a field on the bean information page showing the price per weight ratio of the bean.
Adds a setting to toggle price per weight ratio field.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@graphefruit
Copy link
Owner

Hey @UnknownSilicon,
thanks for the PR and the workload you've done with this.

After there where some PR's lately I've written a new ticket to help everyone before creating a new PR for Beanconqueror: #723

I'm not 100% convinced about the concept made with this code changes.
The calculcation to gram or I'd rather think about 1kg is more or less a function not a parameter which needs to be customized, also it makes it more hard to understand for the users.

I've already recieved some requests to maybe support so show like how much would the bag cost with 1kg, so I'd more take some more reference to this case.
If 1000grams would be added, there wouldn't be any calculcation needed anyway.

The code doesn't handle when you didn't enter any costs but the grams.

So to reduce customization and new labels for this use case:
What does speak against to add it to the <ion-text>{{bean?.cost}}</ion-text> cost field, and add behind in (X/KG) e.g.?
Best
Lars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants