-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Graphile Engine 4.0 docs migrated to build.graphile.org #2309
base: main
Are you sure you want to change the base?
Conversation
|
Looks great; just needs the dropdown issue fixed (as discussed in person) then we can merge! This will break existing links, so may be worth searching the rest of the codebase for |
I've used the solution outlined in facebook/docusaurus#3930 (comment) to avoid the version dropdowns appearing until you're in the docs 👍 |
Description
I noticed we have yet to migrate over the Graphile Engine docs. This is needed before we refresh graphile.org.
The docs on build.graphile.org are now versioned. "Current" is 4.x and "Next" is the new version. This reflects how postgraphile.org is currently.
Almost all of the content is a straight copy from https://www.graphile.org/graphile-build/ with exceptions:
The introduction has a bit at the top taken from https://github.com/graphile/graphile-engine/tree/v4/packages/graphile-build with some new copy explaining the name change to Graphile Build
graphile-build-pg still has its own section, so has its own place within the codebase for versioning. The wording in the overview has been taken from https://github.com/graphile/graphile-engine/tree/v4/packages/graphile-build-pg
I have sneaked in some tweaks to the dark mode contrast
To fix
There's two things I think would be nice to fix, but this can be reviewed and merged without:
...
. It would be nice to replicate this:OLD
NEW