Don't wrapPlans() fields that use resolver emulation only
#2875
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld that both has no plan and either has a `resolve()` or `subscribe()` method (i.e. resolver emulation will be used). This is done by simply skipping wrapping the resolver, and emitting a warning to the console. This is a breaking fix as fields that may have previously had the default plan resolver wrapped may no longer do so, but should not impact anyone running a "pure" PostGraphile/Grafast schema (it only impacts you if you are using traditional (non-plan) resolvers, e.g. via `extendSchema()`, and you're also using `wrapPlans()` to target these same fields).
🦋 Changeset detectedLatest commit: ced4abe The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a field has
resolve()orsubscribe()and noplan()then resolver emulation is used, and the default plan resolver is NOT used. PreviouslywrapPlans()would introduce (and wrap) the default resolver in these cases, which would break resolver emulation. We now refuse to do this.