Skip to content

fix: strip response cache fields from incremental execution result #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Oct 9, 2024

closes #2308

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: d1b16f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/response-cache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/immediate-introspection 4.0.0-alpha-20241009091048-d1b16f9ac9f36dea25e2eb11208fa3cf8fb3f73d npm ↗︎ unpkg ↗︎
@envelop/response-cache 6.2.2-alpha-20241009091048-d1b16f9ac9f36dea25e2eb11208fa3cf8fb3f73d npm ↗︎ unpkg ↗︎
@envelop/sentry 10.0.0-alpha-20241009091048-d1b16f9ac9f36dea25e2eb11208fa3cf8fb3f73d npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Oct 9, 2024

💻 Website Preview

The latest changes are available as preview in: https://72a7565e.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Oct 9, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 773312      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 166278      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 338228      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 166718      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 102088      ✗ 0     
     data_received......................................: 3.0 GB  25 MB/s
     data_sent..........................................: 168 MB  1.4 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.76µs  min=1.25µs   med=2.57µs  max=3.81ms   p(90)=3.34µs  p(95)=3.68µs 
     http_req_connecting................................: avg=9ns     min=0s       med=0s      max=597.69µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.82ms  min=151.2µs  med=2.77ms  max=39.7ms   p(90)=5.13ms  p(95)=6.04ms 
       { expected_response:true }.......................: avg=2.82ms  min=151.2µs  med=2.77ms  max=39.7ms   p(90)=5.13ms  p(95)=6.04ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.34ms  min=401.86µs med=3ms     max=16.57ms  p(90)=5.67ms  p(95)=6.16ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.48ms  min=151.2µs  med=1.23ms  max=19.06ms  p(90)=2.47ms  p(95)=2.62ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.32ms  min=368.15µs med=2.98ms  max=21.04ms  p(90)=5.61ms  p(95)=6.13ms 
     ✓ { mode:graphql-js }..............................: avg=5.61ms  min=934.58µs med=4.85ms  max=39.7ms   p(90)=9.39ms  p(95)=10.15ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 386656
     http_req_receiving.................................: avg=35.04µs min=13.05µs  med=30.42µs max=8.59ms   p(90)=46.33µs p(95)=49.77µs
     http_req_sending...................................: avg=12.83µs min=4.38µs   med=10.35µs max=8.99ms   p(90)=19.73µs p(95)=20.99µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.77ms  min=124.29µs med=2.72ms  max=39.65ms  p(90)=5.08ms  p(95)=5.99ms 
     http_reqs..........................................: 386656  3221.975683/s
     iteration_duration.................................: avg=3.09ms  min=363.55µs med=3.01ms  max=40.47ms  p(90)=5.41ms  p(95)=6.31ms 
     iterations.........................................: 386656  3221.975683/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20  

@n1ru4l n1ru4l requested a review from EmrysMyrddin October 9, 2024 08:57
@n1ru4l n1ru4l merged commit 4fd5917 into main Oct 9, 2024
18 checks passed
@n1ru4l n1ru4l deleted the fix-response-cache-strip-cache-keys-incremental-delivery branch October 9, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

response-cache does not clear cache info from response for incremental delivery
4 participants