-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[DO NOT MERGE] design preview #2483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5a1b425 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are not available as canary, since there are no linked |
6149161
to
0038367
Compare
@thomasheyenbrock and you have canary releases ^^ :) |
a1854d6
to
1ba9df2
Compare
@thomasheyenbrock the canary release tags change on every push fyi! They contain the applicable git short SHA |
if (this.storage) { | ||
this.storage.clear(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.storage) { | |
this.storage.clear(); | |
} | |
this.storage?.clear(); |
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess for accessibility will be better to use button
instead a
{args.length > 0 ? ( | ||
<ExplorerSection title="Arguments"> | ||
{args.map(arg => ( | ||
<Argument key={arg.name} arg={arg} /> | ||
))} | ||
</ExplorerSection> | ||
) : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{args.length > 0 ? ( | |
<ExplorerSection title="Arguments"> | |
{args.map(arg => ( | |
<Argument key={arg.name} arg={arg} /> | |
))} | |
</ExplorerSection> | |
) : null} | |
{args.length > 0 && ( | |
<ExplorerSection title="Arguments"> | |
{args.map(arg => ( | |
<Argument key={arg.name} arg={arg} /> | |
))} | |
</ExplorerSection> | |
)} |
{deprecatedArgs.length > 0 ? ( | ||
showDeprecated || args.length === 0 ? ( | ||
<ExplorerSection title="Deprecated Arguments"> | ||
{deprecatedArgs.map(arg => ( | ||
<Argument key={arg.name} arg={arg} /> | ||
))} | ||
</ExplorerSection> | ||
) : ( | ||
<Button | ||
onClick={() => { | ||
setShowDeprecated(true); | ||
}}> | ||
Show deprecated arguments | ||
</Button> | ||
) | ||
) : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{deprecatedArgs.length > 0 ? ( | |
showDeprecated || args.length === 0 ? ( | |
<ExplorerSection title="Deprecated Arguments"> | |
{deprecatedArgs.map(arg => ( | |
<Argument key={arg.name} arg={arg} /> | |
))} | |
</ExplorerSection> | |
) : ( | |
<Button | |
onClick={() => { | |
setShowDeprecated(true); | |
}}> | |
Show deprecated arguments | |
</Button> | |
) | |
) : null} | |
{deprecatedArgs.length > 0 && ( | |
showDeprecated || args.length === 0 ? ( | |
<ExplorerSection title="Deprecated Arguments"> | |
{deprecatedArgs.map(arg => ( | |
<Argument key={arg.name} arg={arg} /> | |
))} | |
</ExplorerSection> | |
) : ( | |
<Button | |
onClick={() => { | |
setShowDeprecated(true); | |
}}> | |
Show deprecated arguments | |
</Button> | |
) | |
)} |
ChevronDownIcon, | ||
ChevronUpIcon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tip, normally you don't need to have 2 same icons, you can use CSS for rotate your icon :)
@B2o5T thanks for reviewing this 🙏 I'll probably split this huge PR up into smaller increments though to make the individual changes even more reviewable 😉 |
992c78a
to
241bfd1
Compare
88f818d
to
e8e08b8
Compare
4951554
to
3529c06
Compare
0716006
to
21072e4
Compare
aeba740
to
392e02a
Compare
b32018f
to
872b930
Compare
1fcd6b3
to
e937c06
Compare
085e0c4
to
a76dc32
Compare
* add postcss config to allow nesting * avoid processing css from `@graphiql/react` with postcss * add css files for default fonts * add long description with markdown to dev schema * rewrite completion tooltip * move editor css to @graphiql/react * git mv editor components to `@graphiql/react` * adjust editor components after moving to `@graphiql/react` * move styles for auto-inserted leads * make dynamic padding more resilient and add explanatory comment * add extra color to avoid conflicts * colocate markdown and deprecation styles * add changesets * fix spell checking * add changeset for graphiql@2 * don't enter pre-release mode in changeset * more elaborate changeset message
* add icons to `@graphiql/react` * add `UnstyledButton` ui component * implement new design for editors layout * rename `Unstyled` to `UnStyled` for spell checking * remove unused class and whitespace in `className` * make tiny change for deploy preview 🤞 * this will do it, i think? Co-authored-by: Rikki Schulte <[email protected]>
* implement new toolbar design * add `caller` argument for better errors
* implement sidebar in new design * simplify callback
* add icons * don't invoce callback when programmatically change resizable element * implement history in new design * visually separate favourite history items * add save button when editing history label * add changeset * add missing changesets in retrospect * fix typos * fix e2e tests * remove input outline
* move explorer context into folder * move `TypeLink` component to `@graphiql/react` * move `FieldLink` component to `@graphiql/react` * move `DefaultValue` component to `@graphiql/react` * move `Directive` component to `@graphiql/react` * extract `MarkdownContent` component in `@gaphiql/react` * move `Argument` component to `@graphiql/react` * combine and extend changesets
* add icons * add `Button` component to `@graphiql/react` * add explorer section component * redesign `SchemaDocumentation` component * redesign `TypeDocumentation` component * redesign `FieldDocumentation` component * redesign `DocExplorer` component * extend changeset message
a76dc32
to
e4c787d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 65.70% 57.36% -8.34%
==========================================
Files 85 91 +6
Lines 5106 5320 +214
Branches 1631 1699 +68
==========================================
- Hits 3355 3052 -303
- Misses 1747 2250 +503
- Partials 4 18 +14
Continue to review full report at Codecov.
|
e4c787d
to
5a1b425
Compare
All changes have been split up and reviewed incrementally. We collected all of them on the |
Marvelous work thank you! |
The purpose of this PR is just to generate a stable Netlify preview deployment that shows the latest efforts on the new design implementation.